Add maintenance notifications in PAC portal during any related mainte… by vikasbolla · Pull Request #73 · IBM/power-access-cloud

vikasbolla · 2026-04-14T16:35:30Z

Added functionality to display maintenance notifications to PAC users. There is seperate page for admin to manage create, edit, delete, enable/disable maintenance windows.

Notifications appear 24 hours before maintenance starts
Visible during maintenance window
Automatically disappear after end time
overlapping is not allowed, so if admin tries to create new window with time overlapping with existing windows, in that case, we throw error saying to use same window to update the maintenance.

mayuka-c

I'm thinking of this approach than logging to cluster and updating env causing downtime.

Maybe maintain the maintainence state in backend mongoDB with (start date, end date, isMaintainence).
Expose a POST API (strictly restricted to admin), so that the admin can just make API call to update or give them a small toggle button in Admin personna (Enable maintaince or not).
In UI this would greatly simplify as you just need to make the GET call and if yes provide them the maintainence banner.

mayuka-c · 2026-04-15T05:00:28Z

+REACT_APP_MAINTENANCE_NOTIFICATION_ENABLED=false
+REACT_APP_MAINTENANCE_START_TIME=2099-12-31T20:00:00Z
+REACT_APP_MAINTENANCE_END_TIME=2099-12-31T23:59:59Z
+REACT_APP_MAINTENANCE_NOTIFICATION_MESSAGE=Scheduled maintenance in progress. Some services may be temporarily unavailable.


So is the showing maintainece notification a manual process?
If there is maintainence someone need to login to the cluster to update UI deployment env?

If yes, is it fine to do it? because it might not be wise to directly update the ENV in production which causes pod restarts.

Yes I think manually updating by operations folks would not be great. But on pod restrats, it should not cause any downtime as it is rolling update right

But since we have only 1 pod running, rolling update will not help :)

mayuka-c

If possible can we split the PR into 2, first the backend and then the UI changes. Will be easier to review.
Didnt get time to review UI code, will check it later.

Overall approach looks good.

mayuka-c · 2026-04-21T03:19:49Z

 REACT_APP_KEYCLOAK_REALM=pac
 REACT_APP_KEYCLOAK_CLIENT_ID=pac-ui
-REACT_APP_PAC_GO_SERVER_TARGET=http://vm-528.onecloud.stglabs.ibm.com:8000
+REACT_APP_PAC_GO_SERVER_TARGET=http://vm-528.onecloud.stglabs.ibm.com:8000


Pls add new line at end of file

mayuka-c · 2026-04-21T03:22:50Z

 	authorized.POST("/feedbacks", services.CreateFeedback)

+	// maintenance notification related endpoints
+	authorized.GET("/maintenance", services.GetMaintenanceWindows)


Shouldnt GetAllMaintenances be only admin route?

No, We need this call to get the maintenance windows and show the active one to the users

mayuka-c · 2026-04-21T03:24:38Z

+// MaintenanceListResponse is the public response for listing all maintenance windows
+type MaintenanceListResponse struct {
+	Maintenances []MaintenanceResponse `json:"maintenances"`
+}


List of all maintenances is not required for public, this would be required for admin only for auditing or some other purposes

mayuka-c · 2026-04-21T03:28:50Z

+				logger.Error("failed to create event", zap.Error(err))
+			}
+		}()
+		eventLog := fmt.Sprintf("Maintenance window created by admin %s (ID: %s, Enabled: %v)",


Can we have the message too here?

you mean log message?

mayuka-c · 2026-04-21T03:30:53Z

+	if err := dbCon.DeleteMaintenanceWindow(id); err != nil {
+		logger.Error("failed to delete maintenance window from db", zap.Error(err))
+		c.JSON(http.StatusInternalServerError, gin.H{"error": "Failed to delete maintenance window"})
+		return
+	}


For the delete, I feel like doing soft delete with "deleted_at" might be useful, this would help maybe for auditing to know how many maintainces happened for last 6 months etc

ha true, makes sense, will update this, thanks

mayuka-c · 2026-04-21T03:32:31Z

+	// Validate time range
+	if request.EndTime.Before(request.StartTime) || request.EndTime.Equal(request.StartTime) {
+		c.JSON(http.StatusBadRequest, gin.H{"error": "end_time must be after start_time"})
+		return
+	}


I feel at a given time only one maintainence window can be active. So if a maintainence is already active, then do not allow one more maintainence to be created

But,I feel we need to allow them creating them new maintenance if they are at difference timestamp but not allow to multiple maintenance notifications to display to users if the time overlaps.

mayuka-c · 2026-04-21T03:33:02Z

+	var request models.MaintenanceUpdateRequest
+	if err := utils.BindAndValidate(c, &request); err != nil {
+		c.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
+		return
+	}


Similarly in update, you can enable a maintaince window if there are no other maintaince window active

Same here, we can restrict enabling or creating a maintenance window if the time overlaps

mayuka-c · 2026-04-21T03:35:21Z

+func DeleteMaintenanceWindow(c *gin.Context) {
+	logger := log.GetLogger()
+	id := c.Param("id")


I'm wondering do we even need DeleteMaintenance endpoint, as an admin we give them the option to disable the maintainence window and do not require to delete it.

So I feel we just need to add a TTL, lets say if the maintainence is disabled for more than 1year, then simply delete from DB.

mayuka-c · 2026-04-21T03:37:16Z

+	// Validate time range if both times are provided
+	if !request.StartTime.IsZero() && !request.EndTime.IsZero() {
+		if request.EndTime.Before(request.StartTime) || request.EndTime.Equal(request.StartTime) {
+			c.JSON(http.StatusBadRequest, gin.H{"error": "end_time must be after start_time"})
+			return
+		}
+	}


Can we restrict the end time to maybe lets say 15 days since the start time since it was created. Otherwise admin might simply keep updating the same maintainence object over and over which will lose the track of how many maintainence windows were created?

…nance window Signed-off-by: Vikas <vikas.satyanarayana.bolla@ibm.com>

mayuka-c

A minor comment. Rest LGTM

mayuka-c · 2026-04-22T12:28:44Z

+	// Check if admin wants all windows
+	showAll := c.Query("all") == "true"


Can we make this admin only check that is only admin can use this "all" query?

Query param is passed from frontend only for admin

vikasbolla force-pushed the add_maintenance_notification branch 4 times, most recently from d044d95 to e096e8e Compare April 15, 2026 04:35

vikasbolla marked this pull request as ready for review April 15, 2026 04:40

mayuka-c reviewed Apr 15, 2026

View reviewed changes

vikasbolla force-pushed the add_maintenance_notification branch 4 times, most recently from e32999f to 339ba3f Compare April 17, 2026 12:06

mayuka-c reviewed Apr 21, 2026

View reviewed changes

vikasbolla force-pushed the add_maintenance_notification branch 9 times, most recently from 6ff5563 to bdfc702 Compare April 22, 2026 06:20

Add maintenance notifications in PAC portal during any related mainte…

59adc2f

…nance window Signed-off-by: Vikas <vikas.satyanarayana.bolla@ibm.com>

vikasbolla force-pushed the add_maintenance_notification branch from bdfc702 to 59adc2f Compare April 22, 2026 07:03

mayuka-c reviewed Apr 22, 2026

View reviewed changes

		// Check if admin wants all windows
		showAll := c.Query("all") == "true"

Conversation

vikasbolla commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mayuka-c left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mayuka-c left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mayuka-c left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vikasbolla commented Apr 14, 2026 •

edited

Loading

mayuka-c left a comment •

edited

Loading

mayuka-c left a comment •

edited

Loading