Skip to content

Enhance formSelect with aria-label for accessibility #11102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
satyammangroliya wants to merge 1 commit into
base: release_10
Choose a base branch
from
+31 −4
Open

Enhance formSelect with aria-label for accessibility #11102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions components/ILIAS/Table/classes/class.ilTable2GUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2256,8 +2256,12 @@ public function fillActionRow(): void
$button["sel_var"],
$button["options"],
false,
true
true,
0,
"",
array("aria-label" => $lng->txt("action"))
)

);
$this->tpl->setVariable("MI_BTN_NAME", $button["cmd"]);
$this->tpl->setVariable("MI_BTN_VALUE", $button["text"]);
Expand All @@ -2272,8 +2276,12 @@ public function fillActionRow(): void
$button["sel_var"] . "_2",
$button["options"],
false,
true
true,
0,
"",
array("aria-label" => $lng->txt("action"))
)

);
$this->tpl->setVariable("MI_BTN_NAME", $button["cmd"]);
$this->tpl->setVariable("MI_BTN_VALUE", $button["text"]);
Expand All @@ -2299,8 +2307,18 @@ public function fillActionRow(): void
}
$this->tpl->setVariable(
"SELECT_CMDS",
ilLegacyFormElementsUtil::formSelect("", "selected_cmd", $sel, false, true)
ilLegacyFormElementsUtil::formSelect(
"", // selected
"selected_cmd2", // name
$sel, // options
false, // use_multi
true, // submit_after_change
0, // size
"", // css class
array("aria-label" => $lng->txt("action"))
)
);

$this->tpl->setVariable("TXT_EXECUTE", $lng->txt("execute"));
$this->tpl->parseCurrentBlock();
$arrow = true;
Expand All @@ -2320,7 +2338,16 @@ public function fillActionRow(): void
}
$this->tpl->setVariable(
"SELECT_CMDS",
ilLegacyFormElementsUtil::formSelect("", "selected_cmd2", $sel, false, true)
ilLegacyFormElementsUtil::formSelect(
"", // selected
"selected_cmd2", // name
$sel, // options
false, // use_multi
true, // submit_after_change
0, // size
"", // css class
array("aria-label" => $lng->txt("action"))
)
);
$this->tpl->setVariable("TXT_EXECUTE", $lng->txt("execute"));
$this->tpl->parseCurrentBlock();
Expand Down
Loading