[Feature] UI/Init: Remove "Cannot find this block" error handling#11118
Open
mjansenDatabay wants to merge 2 commits intoILIAS-eLearning:trunkfrom
Open
[Feature] UI/Init: Remove "Cannot find this block" error handling#11118mjansenDatabay wants to merge 2 commits intoILIAS-eLearning:trunkfrom
mjansenDatabay wants to merge 2 commits intoILIAS-eLearning:trunkfrom
Conversation
This commit suggests removing the `(new PEAR())->raiseError(...)` call and instead throwing an `ilTemplateException`.
…lock" This commit removes the special error handling for the "Cannot find this block" error formerly raised by the template engine. This is legacy error handling from a time when the template engine used the `PEAR` error handler. All usages (except one) have already been replaced by a proper `ilTemplateException` years ago. The last usage will be addressed by a dedicated commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes legacy
PEARdependencies and outdated error handling from the template engine.Commits
1. Remove last
PEARusage from template testsPEARusage fromcomponents/ILIAS/UI/tests/Renderer/ilIndependentTemplate.phpPEAR2. Remove special "Cannot find this block" error handling
ilErrorHandlingfor template engine errorsPEARerror handlerilTemplateExceptioninstead