Skip to content

feat: set administrator role for user in group iA.Smartweb with an imio address #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remdub merged 3 commits into from
Dec 10, 2025
Merged

feat: set administrator role for user in group iA.Smartweb with an imio address #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4be4c4e
feat: set administrator role for user in group iA.Smartweb with an im…
bsuttor Dec 5, 2025
3ed6a24
feat(role): add manager role to user in iA.Smartweb-admin group
bsuttor Dec 10, 2025
1298be1
chore: update changelog
bsuttor Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
## 1.4.2 (unreleased)


- Nothing changed yet.
- Set administrator role for users in group iA.Smartweb-admin with an imio address.
[bsuttor]


## 1.4.1 (2025-11-25)


- WEB-4331 : Set Allowed Groups with environment variable
[remdub]

Expand All @@ -28,7 +27,6 @@

## 1.3.1 (2025-09-30)


- Do not gave administrator role for users in group iA.Smartweb.
[bsuttor]

Expand Down
14 changes: 10 additions & 4 deletions src/pas/plugins/kimug/plugin/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from zope.interface import implementer

import jwt
import os


# from jwt.algorithms import RSAAlgorithm
Expand Down Expand Up @@ -71,11 +72,16 @@ class KimugPlugin(OIDCPlugin):
@security.private
def getRolesForPrincipal(self, user, request=None):
"""Fulfill RolesPlugin requirements"""
# app_id = os.environ.get("application_id", "smartweb")
app_id = os.environ.get("application_id", "iA.Smartweb")
admin_group = f"{app_id}-admin"
roles = ["Member"]
# if app_id in user.getGroups():
# roles.append("Manager")
# return tuple(roles)
if (
app_id
and admin_group in user.getGroups()
and user.getProperty("email").endswith("@imio.be")
):
roles.append("Manager")
return tuple(roles)
return tuple(roles)

@security.private
Expand Down