Batched strategies - #53
Open
vreshniak wants to merge 37 commits into
Open
Conversation
Do not train surrogate at initialization when dataset_y is empty
`def _extract_y_train_from_dataset` implements cached_property logic
vreshniak
marked this pull request as draft
August 6, 2026 14:42
Do not train surrogate at initialization when dataset_y is empty
`def _extract_y_train_from_dataset` implements cached_property logic
vreshniak
marked this pull request as ready for review
September 9, 2026 12:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support of batch strategies.
Key changes include:
Strategy Handling and API Enhancements
'liar','believer'). The strategy argument types were also expanded to allow lists for more flexible parameterization.ServersideInputMultipleOtherStrategyand related data classes to accept and process the new strategy types and arguments, including batch strategies.Core Logic and Sampling
core.pyto support batch sampling. Now,get_next_pointscan handle the new strategies, delegating to the appropriate selection logic based on the strategy type.strategies.pyforbatch_samplingsupporting both liar and believer batch strategies.Fixes and Minor Improvements
initialize_workflowto only train a model if bothdataset_xand non-emptydataset_yare provided, preventing unnecessary or invalid model training.1e-12) in_transform_Y_params.These changes collectively improve the flexibility, performance, and correctness of the DIAL service's strategy selection and data handling logic.