Fix bootstrap CSS leaks when reusing Dataverse Design System - #1065
Open
julian-schneider wants to merge 3 commits into
Open
Fix bootstrap CSS leaks when reusing Dataverse Design System#1065julian-schneider wants to merge 3 commits into
julian-schneider wants to merge 3 commits into
Conversation
…ng global CSS uses node module resolution instead of loading from a fixed node_modules path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
#1060 describes how reusing the Dataverse Design System leaked Bootstrap CSS into a consuming project. This PR is a proposal how this could be addressed:
$prefix: dv-bs-for Dataverse CSSbootstrap/scss/rebootandbootstrap/scss/typeinto the default stylesheet, since they had major page-level effectsbootstrap-global.cssinto the design-system dist, which does bundlebootstrap/scss/rebootandbootstrap/scss/type. It can be imported on demand, as an opt-in solution for those applications that want it.Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
modern/pages with and without these changes. If this PR is working correctly there should be no differences.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes or changelog update needed for this change?:
Users of the Dataverse Design System should be informed that importing the Bootstrap page-level styles is now opt-in (via
bootstrap-global.css).Additional documentation: