Skip to content

Fix bootstrap CSS leaks when reusing Dataverse Design System - #1065

Open
julian-schneider wants to merge 3 commits into
IQSS:developfrom
julian-schneider:fix/1060-bootstrap-css-leaks
Open

Fix bootstrap CSS leaks when reusing Dataverse Design System#1065
julian-schneider wants to merge 3 commits into
IQSS:developfrom
julian-schneider:fix/1060-bootstrap-css-leaks

Conversation

@julian-schneider

Copy link
Copy Markdown

What this PR does / why we need it:

#1060 describes how reusing the Dataverse Design System leaked Bootstrap CSS into a consuming project. This PR is a proposal how this could be addressed:

  • use $prefix: dv-bs- for Dataverse CSS
  • stop bundling bootstrap/scss/reboot and bootstrap/scss/type into the default stylesheet, since they had major page-level effects
  • introduce the optional bootstrap-global.css into the design-system dist, which does bundle bootstrap/scss/reboot and bootstrap/scss/type. It can be imported on demand, as an opt-in solution for those applications that want it.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

  1. Side-by-side comparison of modern/ pages with and without these changes. If this PR is working correctly there should be no differences.
  2. Use this version of the Dataverse Design System in a non-Bootstrap React project, and check if its CSS has any unwanted side effects. In project seen in the above linked issue's screenshot, no such issues occur anymore.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes or changelog update needed for this change?:

Users of the Dataverse Design System should be informed that importing the Bootstrap page-level styles is now opt-in (via bootstrap-global.css).

Additional documentation:

@pdurbin pdurbin moved this to Ready for Triage in IQSS Dataverse Project Sep 9, 2026
@ChengShi-1 ChengShi-1 moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for Review ⏩

Development

Successfully merging this pull request may close these issues.

Reuse of design-system components leaks CSS into the consuming project

3 participants