Skip to content

fix: localize dynamic values and controlled labels (#1063) - #1066

Open
youseihuayu-wonderful wants to merge 1 commit into
IQSS:developfrom
youseihuayu-wonderful:fix/1063-localize-dynamic-values
Open

fix: localize dynamic values and controlled labels (#1063)#1066
youseihuayu-wonderful wants to merge 1 commit into
IQSS:developfrom
youseihuayu-wonderful:fix/1063-localize-dynamic-values

Conversation

@youseihuayu-wonderful

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

  • Format dates, file sizes, and counts using the active interface language.
  • Localize known file types, system categories, facet headings, and Subject values.
  • Preserve custom metadata, raw filter values, and dataset version identifiers.
  • Prevent inherited object properties from being treated as translation keys.

Which issue(s) this PR closes:

Special notes for your reviewer:

Frontend-only changes; no backend API or dependency changes.

Suggestions on how to test this:

  • Switch between English and Spanish and verify dates, sizes, and counts.
  • Add and remove translated facets.
  • Verify custom values, including constructor and toString, remain unchanged.
  • Verify download sizes update after changing the interface language.

Validation: 121 passing tests across 16 affected specs; Node 22 build,
scoped ESLint, Prettier, and browser component smoke checks passed.
Full backend E2E was not run.

Does this PR introduce a user interface change?

Yes: localized display values and labels; no layout changes.

Is there a release notes or changelog update needed?

Updated CHANGELOG.md under Unreleased / Fixed.

Additional documentation:

None.

@youseihuayu-wonderful

Copy link
Copy Markdown
Contributor Author

Hi Chen, I’ve opened a PR for #1063: #1066
The fix covers locale-aware formatting and localized file/facet labels while preserving user-provided metadata and raw filter values. Local validation passed; GitHub CI was still running at my last check.
@ChengShi-1 Could you take a look when you are free?

@pdurbin pdurbin moved this to Ready for Triage in IQSS Dataverse Project Sep 9, 2026
@ChengShi-1 ChengShi-1 moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for Review ⏩

Development

Successfully merging this pull request may close these issues.

Some dynamic values and search facets are not localized in the Modern Frontend

3 participants