fix(#894): display facet name alongside facet value in selected filter chips - #1067
Open
Janvi-kapoor wants to merge 3 commits into
Open
fix(#894): display facet name alongside facet value in selected filter chips#1067Janvi-kapoor wants to merge 3 commits into
Janvi-kapoor wants to merge 3 commits into
Conversation
Author
|
Hi @ChengShi-1 👋 Just an update on PR #1067: I've resolved the linting error directly on GitHub. The core tests (Components, E2E, and Accessibility/Interaction) have already successfully passed. Could you please trigger or re-run the checks, or let me know if you have any other feedback on this? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When selecting a facet filter in the collection items view, the filter chip above the results only displayed the facet value (e.g.
2024 ×) instead of the facet name and value combined (e.g.Publication Year: 2024 ×).This PR:
facetslist fromCollectionItemsPaneltoSelectedFacets.SelectedFacetsto look up the facet'sfriendlyNameby matchingfilterQueryKey, rendering<Facet Name>: <Facet Value>.filterQueryKeyif no matching facet object is found.Which issue(s) this PR closes:
Special notes for your reviewer:
js-dataversechange is needed. TheCollectionItemsFacetmodel already providesnameandfriendlyNamein the frontend.@IQSS/dataverse-client-javascriptpackage requires GitHub registry authentication, I verified the logic and test cases via isolated execution. I look forward to CI checks on this PR.Suggestions on how to test this:
Publication Year: 2024 ×instead of just2024 ×.×button on the chip and verify the filter is removed as expected.cypress run --component --spec "tests/component/sections/collection/collection-items-panel/SelectedFacets.spec.tsx"Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes. Applied facet filter buttons above results now render
<Facet Name>: <Facet Value> ×instead of only<Facet Value> ×.Is there a release notes or changelog update needed for this change?:
Yes, updated
CHANGELOG.mdunder[Unreleased] -> ### Fixed.Additional documentation:
None.