fix(#1003): fallback to draft version on dataset page when no version… - #1068
Open
Janvi-kapoor wants to merge 1 commit into
Open
fix(#1003): fallback to draft version on dataset page when no version…#1068Janvi-kapoor wants to merge 1 commit into
Janvi-kapoor wants to merge 1 commit into
Conversation
…sion param is provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When accessing a dataset page without an explicit version query parameter, the repository defaults to fetching
:latest-published. For draft-only datasets, this request returns a 404 error, preventing authorized users (such as creators accessing datasets from notifications) from viewing their draft dataset.This PR updates
DatasetJSDataverseRepository.getByPersistentId:requestedVersionis provided and the initial:latest-publishedrequest fails, it attempts a fallback to:draft.:draftrequest also fails (e.g. for unauthorized users lacking draft-view permissions), it throws the error normally.Which issue(s) this PR closes:
Special notes for your reviewer:
DatasetJSDataverseRepository) as discussed in the issue thread.Suggestions on how to test this:
versionquery parameter (/datasets?persistentId=<doi>).Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes or changelog update needed for this change?:
Yes, updated
CHANGELOG.mdunder[Unreleased] -> ### Fixed.Additional documentation:
None.