Skip to content

Change the requirement to display thumbnails from "thumbnailFile != null" to not useGenericThumbnail #12666 #12667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juancorr wants to merge 1 commit into
base: develop
Choose a base branch
from
+1 −1
Open

Change the requirement to display thumbnails from "thumbnailFile != null" to not useGenericThumbnail #12666 #12667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/edu/harvard/iq/dataverse/Dataset.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,7 @@ public void setThumbnailFile(DataFile thumbnailFile) {
}

public String getThumbnailUrl() {
return thumbnailFile != null ? SystemConfig.getDataverseSiteUrlStatic() + "/api/datasets/" + this.getId() + "/logo" : null;
return !useGenericThumbnail ? SystemConfig.getDataverseSiteUrlStatic() + "/api/datasets/" + this.getId() + "/logo" : null;

@qqmyers qqmyers Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I was wondering whether isPreviewImageAvailable() would be a better choice, but it looks like that is mostly kept in sych with useGenericThumbnail (i.e. they are opposites).

@pdurbin pdurbin Sep 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm requesting a review from @stevenwinship (no rush) because he most recently worked on this logic in the following PR:

}

public boolean isUseGenericThumbnail() {
Expand Down
Loading