Skip to content

Fix double-escaped directApiCall URL in OAI-PMH metadata #12684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
igorzelaya-io wants to merge 1 commit into
base: develop
Choose a base branch
from
+13 −1
Open

Fix double-escaped directApiCall URL in OAI-PMH metadata #12684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/edu/harvard/iq/dataverse/harvest/server/xoai/DataverseXoaiItemRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ private Metadata getDatasetMetadata(Dataset dataset, String metadataPrefix) thro

private String customDataverseJsonApiUri(String identifier) {
String ret = serverUrl
+ "/api/datasets/export?exporter=dataverse_json&persistentId="
+ "/api/datasets/export?exporter=dataverse_json&persistentId="
+ identifier;

return ret;
Expand Down
12 changes: 12 additions & 0 deletions src/test/java/edu/harvard/iq/dataverse/api/HarvestingServerIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,18 @@ public void testSingleRecordOaiSet() throws InterruptedException {
assertEquals("Darwin's finches (also known as the Galápagos finches) are a group of about fifteen species of passerine birds.",
responseXmlPath.getString("OAI-PMH.GetRecord.record.metadata.dc.description"));
assertEquals("Medicine, Health and Life Sciences", responseXmlPath.getString("OAI-PMH.GetRecord.record.metadata.dc.subject"));

Response dataverseJsonRecordResponse =
UtilIT.getOaiRecord(singleSetDatasetPersistentId, "dataverse_json");
assertEquals(OK.getStatusCode(), dataverseJsonRecordResponse.getStatusCode());
responseXmlPath = validateOaiVerbResponse(dataverseJsonRecordResponse, "GetRecord");
String directApiCall =
responseXmlPath.getString(
"OAI-PMH.GetRecord.record.metadata.dataverse_json.@directApiCall");
assertTrue(
directApiCall.endsWith(
"/api/datasets/export?exporter=dataverse_json&persistentId="
+ singleSetDatasetPersistentId));

// ok, looks legit!

Expand Down