Feature/sw architecture#2
Conversation
There was a problem hiding this comment.
In general looks good, but some improvements are needed.
I've mostly pointed out missing docstrings and other comments, but there are also some code change suggestions and questions.
You should also add documentation (installation and usage).
As I have made a review per commits, there may be some outdated commend left. I went through all the files from all commits again and cleaned them, but it's possible I've missed some.
I have also tested the code locally by running the containers. I have not tested services that are currently not containers.
|
|
||
| To start the Ingest Service run `make run-local-dev` from this directory. This will create a Python | ||
| virtual environment, install the required dependencies, and start the service on | ||
| `http://localhost:50005`. |
There was a problem hiding this comment.
Mention that this applies for developing, but for prod, the docker compose should be used.
There was a problem hiding this comment.
- consider adding some exception handling, at least for database operations
- consider adding pagination or at least limit the number of results returned
Description
This PR introduces the key system components for the backend architecture. These include:
mockdirectory)Closes #1
Areas of interest for the reviewer
Please review the code in the following order:
After reviewing you can test the application if you wish to do so, this is not necessary.
Checklist
After-review steps