Conversation
tli26
marked this pull request as draft
July 19, 2023 00:36
tli26
marked this pull request as ready for review
July 19, 2023 00:36
The event should be sent to the javascript listeners, not broadcasted to the iOS notification center. Add typescript type for the event.
…l-checks bugfix: add missing null checks to CompanionScanner
ios: fix willRestoreState event
…ded example apps yarn locks.
…ded example apps yarn locks.
…spec to support both architechtures, fix imports on ios.
…crash Add validation for BLE UUID format (16-bit and 128-bit) before creating CBUUID instances. Invalid UUID strings now return an error callback instead of causing app crashes.
Implement a method to validate both 16-bit and 128-bit BLE UUID formats, ensuring that invalid UUID strings are handled gracefully.
Add a check to ensure that if serviceUUIDs are provided but all are invalid, an error message is logged and a callback is returned, preventing further processing.
…and DefaultScanManager to prevent crashes
fix(ios,android): add UUID validation to prevent crashes and fix scan behavior
The didDiscoverServices, didDiscoverCharacteristicsFor, and didDiscoverDescriptorsFor delegate callbacks all returned early on error without invoking the JS callback or clearing the discovery latches. This caused the retrieveServices promise to never resolve. Now errors properly propagate to the callback, and the latch system correctly handles errors and services with zero characteristics.
Fix retrieveServices hanging forever on iOS when service discovery fails
Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.8.1 to 2.9.0. - [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md) - [Commits](sporkmonger/addressable@addressable-2.8.1...addressable-2.9.0) --- updated-dependencies: - dependency-name: addressable dependency-version: 2.9.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.8.7 to 2.9.0. - [Changelog](https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md) - [Commits](sporkmonger/addressable@addressable-2.8.7...addressable-2.9.0) --- updated-dependencies: - dependency-name: addressable dependency-version: 2.9.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
CoreBluetooth's `localizedDescription` is a locale-dependent system string that Apple does not contract to keep stable across iOS releases.
Consumers needing to distinguish specific failures (e.g.`CBATTErrorInsufficientEncryption` — the failure surfaced when the user cancels the iOS pairing PIN dialog, code 15 in domain `CBATTErrorDomain`) currently have to string match on English text, which breaks on non-English devices and may break on future iOS versions.
Replace the bare `error.localizedDescription` string passed to JS callbacks with a `{ code, domain, message }` dictionary, matching the structured payload already emitted by `didDisconnectPeripheral` and `didUpdateNotificationStateFor`.
BREAKING CHANGE: JS-side error parameter for `read`, `write`, `connect`, `retrieveServices`, `readRSSI`, `readDescriptor`, and `writeDescriptor` is now an object rather than a string on iOS. The human-readable text is still available as `error.message`; callers who only logged it (`console.error(err)`) continue to work since both strings and dicts serialize sensibly.
fix(ios): emit structured { code, domain, message } on callback errors
…ressable-2.9.0 Bump addressable from 2.8.1 to 2.9.0 in /example
…sable-2.9.0 Bump addressable from 2.8.7 to 2.9.0 in /docs
…vice fix: can't disconnect ble on Android
Bumps [concurrent-ruby](https://github.com/ruby-concurrency/concurrent-ruby) from 1.2.2 to 1.3.7. - [Release notes](https://github.com/ruby-concurrency/concurrent-ruby/releases) - [Changelog](https://github.com/ruby-concurrency/concurrent-ruby/blob/master/CHANGELOG.md) - [Commits](ruby-concurrency/concurrent-ruby@v1.2.2...v1.3.7) --- updated-dependencies: - dependency-name: concurrent-ruby dependency-version: 1.3.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.8.10 to 0.8.15. - [Release notes](https://github.com/xmldom/xmldom/releases) - [Changelog](https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md) - [Commits](xmldom/xmldom@0.8.10...0.8.15) --- updated-dependencies: - dependency-name: "@xmldom/xmldom" dependency-version: 0.8.15 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…in extension AGP 9 ships built-in Kotlin support and registers the kotlin extension itself. Applying the Kotlin plugin again fails configuration with "Cannot add extension with name 'kotlin'". Check for the extension directly, which needs no AGP version table and covers AGP 10, where the android.builtInKotlin opt-out is removed.
…e/xmldom/xmldom-0.8.15 Bump @xmldom/xmldom from 0.8.10 to 0.8.15 in /example
…current-ruby-1.3.7 Bump concurrent-ruby from 1.2.2 to 1.3.7 in /example
fix(android): skip explicit Kotlin plugin when AGP registers the kotlin extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.