Skip to content

feat(elt-pipelines): Add computing schema - #471

Open
ambolt314 wants to merge 1 commit into
mainfrom
468_computing_custom_schema
Open

feat(elt-pipelines): Add computing schema#471
ambolt314 wants to merge 1 commit into
mainfrom
468_computing_custom_schema

Conversation

@ambolt314

Copy link
Copy Markdown
Contributor

Summary

Add custom schema to delineate computing models apart from analytics models

Fixes #468 .

@ambolt314
ambolt314 requested a review from a team as a code owner September 11, 2026 09:49
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 53955b0d-6363-49f3-9eab-3da56864e9b8

📥 Commits

Reviewing files that changed from the base of the PR and between 7095b14 and 326494b.

📒 Files selected for processing (1)
  • elt-pipelines/facility_ops/transform/dbt_project.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The dbt project now defines a computing collection under facility_ops.marts. Models in this collection are materialised as tables and use the computing schema.

Changes

Facility operations computing marts

Layer / File(s) Summary
Configure computing marts schema
elt-pipelines/facility_ops/transform/dbt_project.yml
Adds the computing marts collection with table materialisation and the computing schema.

Suggested reviewers: whtaylor

Priority: ⬇️ Low

Change: Feature

Merge Risk: ⚪ Minimal · up to 32649

The change is limited to configuring computing marts to use the intended schema, with no unresolved merge risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding a computing schema to the facility operations dbt project.
Description check ✅ Passed The description explains that the change separates computing models from analytics models and references issue #468.
Linked Issues check ✅ Passed Issue #468 requires a computing model configuration with +schema: computing in elt-pipelines/facility_ops/transform/dbt_project.yml. The reviewed file contains facility_ops.marts.computing wit…
Out of Scope Changes check ✅ Passed The supplied pull request summary reports changes only to elt-pipelines/facility_ops/transform/dbt_project.yml, with two added lines for the computing model collection. These changes directly impl…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@martyngigg martyngigg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the computing models now end up in analytics_computing:

...
12:17:44  4 of 7 OK created sql table model analytics_computing.time_in_status_computing_infrastructure  [CREATE TABLE (36 rows) in 3.39s]
12:17:44  5 of 7 OK created sql table model analytics_computing.time_in_status_data_driven_facility  [CREATE TABLE (40 rows) in 3.40s]
12:17:44  6 of 7 OK created sql table model analytics_computing.time_in_status_scientific_software  [CREATE TABLE (163 rows) in 3.41s]
12:17:44  7 of 7 OK created sql table model analytics_computing.time_in_status_user_software  [CREATE TABLE (148 rows) in 3.41s]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add custom schema name for computing models in dbt_project.yml

2 participants