Skip to content

Extend TensorAlgebra's twist! instead of owning the generic function - #287

Merged
mtfishman merged 3 commits into
mainfrom
mf/twist-interface
Oct 7, 2026
Merged

mtfishman merged 3 commits into
mainfrom
mf/twist-interface

Conversation

@mtfishman

@mtfishman mtfishman commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Summary

Moves the AbstractArray fallback to TensorAlgebra and makes the GradedArray and UniqueSectorArray methods extend TA.twist!, so a package that cannot depend on GradedArrays can still reach the twist through the TensorAlgebra interface.

mtfishman and others added 2 commits October 6, 2026 17:18
Moves the `AbstractArray` fallback to TensorAlgebra and makes the `GradedArray` and `UniqueSectorArray` methods extend `TA.twist!`, so a package that cannot depend on GradedArrays can still reach the twist through the TensorAlgebra interface.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 85.53%. Comparing base (7be16c3) to head (a59519b).

Files with missing lines Patch % Lines
src/uniquesectorarray.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   85.53%   85.53%   -0.01%     
==========================================
  Files          40       40              
  Lines        2821     2820       -1     
==========================================
- Hits         2413     2412       -1     
  Misses        408      408              
Flag Coverage Δ
docs 18.61% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@mtfishman mtfishman changed the title [WIP] Extend TensorAlgebra's twist! instead of owning the generic function Extend TensorAlgebra's twist! instead of owning the generic function Oct 7, 2026
@mtfishman
mtfishman marked this pull request as ready for review October 7, 2026 01:44
@mtfishman
mtfishman enabled auto-merge (squash) October 7, 2026 01:47
@mtfishman
mtfishman merged commit a56728d into main Oct 7, 2026
25 of 29 checks passed
@mtfishman
mtfishman deleted the mf/twist-interface branch October 7, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant