Repository navigation
Support scalar on rank-0 GPU arrays - #244
Merged
Merged
Conversation
`scalar(a) = a[]` is a scalar index, which GPU array packages disallow, so reading the
result of a full contraction of `CuArray`s threw. A `GPUArraysCore` extension adds
`scalar(a::AnyGPUArray{<:Any, 0}) = @allowscalar a[]`, which copies the element to the
host; other arrays keep the generic `a[]`. Bump the version to 0.23.3.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #244 +/- ##
==========================================
+ Coverage 83.81% 83.83% +0.01%
==========================================
Files 30 31 +1
Lines 970 971 +1
==========================================
+ Hits 813 814 +1
Misses 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scalar(a) = a[]is a scalar index, which GPU array packages disallow, so reading the result of a full contraction ofCuArrays threw. AGPUArraysCoreextension addsscalar(a::AnyGPUArray{<:Any, 0}) = @allowscalar a[], which copies the element to the host; other arrays keep the generica[]. Bump the version to 0.23.3.