Skip to content

Update README.md - #119

Open
kboenke wants to merge 1 commit into
Icinga:masterfrom
kboenke:patch-1
Open

Update README.md#119
kboenke wants to merge 1 commit into
Icinga:masterfrom
kboenke:patch-1

Conversation

@kboenke

@kboenke kboenke commented Jan 27, 2024

Copy link
Copy Markdown

Values defined through env-vars must be quoted in order to be correctly placed in .ini-files. Otherwise they will not be interpreted properly.

Values defined through env-vars must be quoted in order to be correctly placed in .ini-files. Otherwise they will not be interpreted properly.
@cla-bot

cla-bot Bot commented Jan 27, 2024

Copy link
Copy Markdown

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @kboenke

Details
  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

@lippserd

Copy link
Copy Markdown
Member

@cla-bot check

@cla-bot cla-bot Bot added the cla/signed label Jan 29, 2024
@lippserd

Copy link
Copy Markdown
Member

Thanks for the contribution.

@lippserd

Copy link
Copy Markdown
Member

Hi @kboenke,

What exactly do you want to fix with this PR, i.e. what is not interpreted correctly?

Best regards,
Eric

@adn77

adn77 commented Apr 17, 2024

Copy link
Copy Markdown

@lippserd this is actually a major pitfall for first-time users. It took me two weeks to figure out I need to put certain attributes in quotes (probably those containing special characters).

I ended up using a combination of single and double quotes, e.g.:

environment:
  icingaweb.resources.ad-ldap.bind_dn: '"idp@example.org"'

What still doesn't work is something like:

environment:
  icingaweb.modules.generictts.config.onboard.pattern: '/#([0-9]+)/'

I looked at the code of the go-ini library but didn't really get anywhere

@Al2Klimov

Copy link
Copy Markdown
Member

The problem isn't that the users aren't told to quote properly, the problem is that the entrypoint doesn't quote properly:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants