-
Notifications
You must be signed in to change notification settings - Fork 0
Prepare admin app for Vercel deployment #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IgnazioDS
wants to merge
1
commit into
main
Choose a base branch
from
branch/vercel-admin-ready
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,293
−422
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,7 @@ venv/ | |
| *.dylib | ||
| *.dll | ||
| *.exe | ||
| SentinelID_Audit_v*.pdf | ||
| dist/ | ||
| build/ | ||
| output/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "extends": [ | ||
| "next/core-web-vitals" | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| # SentinelID Admin | ||
|
|
||
| This Next.js app is the Vercel deployment target for the SentinelID admin dashboard. | ||
|
|
||
| ## Vercel Setup | ||
|
|
||
| Create a Vercel project with the repository connected and set the project root directory to `apps/admin`. | ||
|
|
||
| Required environment variables: | ||
|
|
||
| - `CLOUD_BASE_URL`: Absolute base URL for the SentinelID cloud API. Use the public HTTPS origin in production. | ||
| - `ADMIN_API_TOKEN`: Server-side admin token injected by the proxy route. | ||
| - `ADMIN_UI_USERNAME`: Login username for the admin dashboard. | ||
| - `ADMIN_UI_PASSWORD_HASH` or `ADMIN_UI_PASSWORD_HASH_B64`: Bcrypt hash for the admin password. `ADMIN_UI_PASSWORD_HASH_B64` is the safer option when pasting values into hosted environments. | ||
| - `ADMIN_UI_SESSION_SECRET`: Secret used to sign the HttpOnly admin session cookie. | ||
|
|
||
| Optional environment variables: | ||
|
|
||
| - `ADMIN_UI_SESSION_TTL_MINUTES`: Session duration in minutes. Defaults to `480`. | ||
| - `ADMIN_UI_SESSION_SECURE`: Set to `1` in production to force secure cookies. On Vercel this can usually be omitted because HTTPS is detected from forwarded headers. | ||
| - `NEXT_PUBLIC_CLOUD_BASE_URL`: Fallback only if `CLOUD_BASE_URL` is not set. | ||
|
|
||
| ## Local Verification | ||
|
|
||
| ```bash | ||
| npm install | ||
| npm run lint | ||
| npm run build | ||
| ``` | ||
|
|
||
| ## Deploy | ||
|
|
||
| Recommended monorepo flow: | ||
|
|
||
| ```bash | ||
| cd /path/to/SentinelID | ||
| vercel link --repo | ||
| ``` | ||
|
|
||
| In the Vercel project settings, set the Root Directory to `apps/admin`. After that, deployments can run from the repository root with the linked project: | ||
|
|
||
| ```bash | ||
| vercel | ||
| ``` | ||
|
|
||
| For production: | ||
|
|
||
| ```bash | ||
| vercel --prod | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Select the fallback only after normalizing
CLOUD_BASE_URL; with the currentprocess.env.CLOUD_BASE_URL || process.env.NEXT_PUBLIC_CLOUD_BASE_URLorder, a whitespace-only or quote-wrapped emptyCLOUD_BASE_URLis treated as present and prevents fallback, causing startup to fail even whenNEXT_PUBLIC_CLOUD_BASE_URLis valid. The prior implementation trimmed before||, so this is a behavior regression for misconfigured-but-recoverable env setups.Useful? React with 👍 / 👎.