feat(chips-area): add separate theme#17205
Open
adrianptrv wants to merge 2 commits intosimeonoff/scoped-stylesfrom
Open
feat(chips-area): add separate theme#17205adrianptrv wants to merge 2 commits intosimeonoff/scoped-stylesfrom
adrianptrv wants to merge 2 commits intosimeonoff/scoped-stylesfrom
Conversation
adrianptrv
added
❌ status: awaiting-test
desig9stein
added
👀 status: in-review
desig9stein
reviewed
Apr 20, 2026
| flex-wrap: wrap; | ||
| width: 100%; | ||
|
|
||
| &:empty { |
Contributor
There was a problem hiding this comment.
Not sure why we need empty; the area is never empty, even when no chips are present. Can you test to see what happens if you remove it?
Contributor
Author
There was a problem hiding this comment.
In the Grid context, the empty state is never reached because the drop-area element remains inside the chips-area even when no chips are added. However, when the chips-area is used independently outside of the grid, the empty state is applied whenever no chips are present. If we remove the 'empty' selector; on the empty state, the chips-area element will still be displayed, but with 0px height:
desig9stein
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16769