fix(for-of): call recalcUpdateSizes via afterNextRender in zoneless mode#17325
Open
viktorkombov wants to merge 3 commits into
Open
fix(for-of): call recalcUpdateSizes via afterNextRender in zoneless mode#17325viktorkombov wants to merge 3 commits into
viktorkombov wants to merge 3 commits into
Conversation
viktorkombov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes virtual scroll size cache updates in Angular zoneless change detection by scheduling recalcUpdateSizes() via afterNextRender when NgZone is NoopNgZone, preventing clipped last rows after scrolling (MRL grids regression).
Changes:
- Updated
IgxForOfDirective/IgxGridForOfDirectivescroll handlers to callrecalcUpdateSizes()viaafterNextRender(...read...)in zoneless mode, while preserving the existingzone.onStablepath in zone-based mode. - Updated
IgxGridBaseDirectiveresize notification handling to skipzone.run()in zoneless mode. - Added a unit test to verify
recalcUpdateSizesis invoked after vertical scroll underprovideZonelessChangeDetection().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/grid/src/grid-base.directive.ts | Avoids zone.run() in zoneless mode for resize-triggered work while still notifying changes. |
| projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.ts | Adds zoneless-aware scheduling of recalcUpdateSizes() via afterNextRender in multiple scroll handlers. |
| projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.spec.ts | Adds a zoneless unit test ensuring recalcUpdateSizes() runs after vertical scroll. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17280
Description
In zoneless Angular (
provideZonelessChangeDetection),NoopNgZone.onStablenever emits, sorecalcUpdateSizes()was never called after scrolling. This left the virtual scroll size cache uncorrected, causing the last visible row in MRL grids to appear partially clipped.Motivation / Context
In
for_of.directive.ts, at all three scroll handler sites, detect zoneless mode and useafterNextRender({ read: () => recalcUpdateSizes() })instead ofzone.onStable.pipe(first()).subscribe(recalcUpdateSizes). Zone mode keeps the original path unchanged (replacing it unconditionally breaks an existing zone-based scroll test).In
grid-base.directive.ts, the resizeNotify handler skips zone.run() in zoneless mode -notifyChanges()already callsmarkForCheck()which schedules CD via the zoneless scheduler.Type of Change (check all that apply):
Component(s) / Area(s) Affected:
Grid, For-of
How Has This Been Tested?
Added a zoneless describe block in
for_of.directive.spec.tsverifyingrecalcUpdateSizesis called after scroll when usingprovideZonelessChangeDetection.Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)