Skip to content

fix(chart): restrict ClusterRole to least-privilege permissions - #93

Merged
enriqueavindi merged 1 commit into
InditexTech:mainfrom
hawikk:fix/chart-least-privilege-rbac
Oct 9, 2026
Merged

enriqueavindi merged 1 commit into
InditexTech:mainfrom
hawikk:fix/chart-least-privilege-rbac

Conversation

@hawikk

@hawikk hawikk commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Aligns the Helm chart ClusterRole with config/rbac/role.yaml (and the OLM CSV permissions).

Removes the chart-wide */* get/list/watch rule and namespace create/delete/update/patch. Keeps explicit rules for the resources the controllers and webhooks use, adds namespaces get/list/watch for label lookups, keeps the view ClusterRoleBinding, adds patch on deployments/replicasets to match the generated role, and drops a duplicated update verb.

Also updates the short RBAC note in docs/architecture.md so it points at the generated role instead of an incomplete snippet.

Closes #92

Checklist

Additional context

  • helm lint chart and helm template succeed with the updated template.
  • SubjectAccessReview checks on the rendered ClusterRole: verbs used by the code are ALLOW; secrets get/list/watch and namespace create/delete/update are DENY.
  • deploy/chart/<version>/ is left unchanged; those trees are copied from chart/ on release (make target copies chart/* into deploy/chart/$(VERSION)/).

@hawikk
hawikk requested a review from a team as a code owner October 8, 2026 21:32
@signoff-validator

Copy link
Copy Markdown

Contribution License Agreement - Valid 🟢

All commits contain valid signoff. As a confirmation, remember that you are agreeing to our Contribution License Agreement.

@enriqueavindi
enriqueavindi merged commit 1369e53 into InditexTech:main Oct 9, 2026
13 checks passed
@enriqueavindi enriqueavindi mentioned this pull request Oct 9, 2026
5 tasks done
enriqueavindi added a commit that referenced this pull request Oct 9, 2026
Prepare patch release 1.3.4.

- Update active operator, Helm, catalog and documentation version
  references from 1.3.3 to 1.3.4.
- Regenerate the OLM bundle for 1.3.4 so chart RBAC templates and the
  clusterserviceversion carry the least-privilege RBAC from #93 and the
  governance sync from #82; the bundle in the 1.3.3 tree predated them,
  which made the release workflow's 'Check bundle generation' step fail
  on tag 1.3.3. Versioned artifacts of previous releases stay frozen.
- Add the versioned OLM and Helm release artifacts for 1.3.4.

Signed-off-by: Enrique Andrés Villar <enriqueavi@inditex.com>
enriqueavindi added a commit that referenced this pull request Oct 9, 2026
Prepare patch release 1.3.4.

- Update active operator, Helm, catalog and documentation version
  references from 1.3.3 to 1.3.4.
- Regenerate the OLM bundle for 1.3.4 so chart RBAC templates and the
  clusterserviceversion carry the least-privilege RBAC from #93 and the
  governance sync from #82; the bundle in the 1.3.3 tree predated them,
  which made the release workflow's 'Check bundle generation' step fail
  on tag 1.3.3. Versioned artifacts of previous releases stay frozen.
- Add the versioned OLM and Helm release artifacts for 1.3.4.

Signed-off-by: Enrique Andrés Villar <enriqueavi@inditex.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Align Helm chart ClusterRole with least-privilege permissions

2 participants