Repository navigation
Shape label: use the native-canvas text engine and editor session - #1237
Merged
Merged
Conversation
jesusmpc
marked this pull request as ready for review
October 26, 2026 13:39
jesusmpc
changed the title
Rectangle, ellipse and polygon can select config.label.engine ('native') to
render labels with the native-canvas text engine and edit them with
TextEditSession, with rich text and optional labelBlocks. 'legacy' stays
the default.
Also stop the text-v2 Enter keypress handler from cancelling Enter typed in
other editors, and sync the OpenSpec specs and archives (shape-label engine,
text-v2 rich text).
Move the completed text-v2-rich-text change to the archive and update the text-v2 editing and layout specs and the new rich-text-api spec.
Contributor
❗ This Pull Request will not trigger a docs releaseA Pull Request with no |
1 similar comment
Contributor
❗ This Pull Request will not trigger a docs releaseA Pull Request with no |
Extract the mutex lock, selection suspend/resume, label height fit and label commit into shape-label.edit-shared, and the stage coordinate mapping into text-v2/edit/stage-coordinates, so the legacy and native label editors and the text-v2 node stop duplicating them (SonarCloud new-code duplication gate).
Contributor
❗ This Pull Request will not trigger a docs releaseA Pull Request with no |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1226
Summary
OpenSpec change proposal (planning artifacts only, no code) to let shape labels (rectangle, ellipse, polygon) use the native-canvas text engine and
TextEditSession.legacy(currentKonva.Text+ DOM textarea);nativeis opt-in via node config. No breaking change, no persisted schema change.ShapeLabelEngineseam; legacy editor kept as-is.shape-label/engine, design, tasks.Open items
WeaveTextV2Shape(spikes in tasks).Status
Draft: for review of the plan before implementation.