-
Notifications
You must be signed in to change notification settings - Fork 39
feature(eng-5200): support domain in .infisical.json and INFISICAL_DOMAIN env var #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| package util | ||
|
|
||
| import ( | ||
| "os" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestWorkspaceConfigDomain(t *testing.T) { | ||
| cases := []struct { | ||
| name string | ||
| path string | ||
| wantDomain string | ||
| }{ | ||
| {"domain field is parsed", "testdata/infisical-with-domain.json", "https://custom.infisical.com"}, | ||
| {"existing config without a domain field parses to empty", "testdata/infisical-default-env.json", ""}, | ||
| } | ||
|
|
||
| for _, tc := range cases { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| cfg, err := GetWorkspaceConfigByPath(tc.path) | ||
| if err != nil { | ||
| t.Fatalf("unexpected error: %v", err) | ||
| } | ||
| if cfg.Domain != tc.wantDomain { | ||
| t.Errorf("Domain = %q, want %q", cfg.Domain, tc.wantDomain) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestGetEnvDomain(t *testing.T) { | ||
| const unset = "\x00" // sentinel: leave the env var unset for this case | ||
|
|
||
| cases := []struct { | ||
| name string | ||
| domain string // INFISICAL_DOMAIN | ||
| apiURL string // INFISICAL_API_URL (legacy) | ||
| wantVal string | ||
| wantOk bool | ||
| }{ | ||
| {"prefers INFISICAL_DOMAIN over legacy", "https://domain.infisical.com", "https://apiurl.infisical.com", "https://domain.infisical.com", true}, | ||
| {"falls back to legacy INFISICAL_API_URL", unset, "https://apiurl.infisical.com", "https://apiurl.infisical.com", true}, | ||
| {"blank INFISICAL_DOMAIN falls through to legacy", " ", "https://apiurl.infisical.com", "https://apiurl.infisical.com", true}, | ||
| {"neither set", unset, unset, "", false}, | ||
| {"both blank are treated as unset", " ", " ", "", false}, | ||
| } | ||
|
|
||
| setOrUnset := func(t *testing.T, key, val string) { | ||
| t.Helper() | ||
| t.Setenv(key, "") // register restore-on-cleanup, then mutate freely below | ||
| if val == unset { | ||
| os.Unsetenv(key) | ||
| return | ||
| } | ||
| os.Setenv(key, val) | ||
| } | ||
|
|
||
| for _, tc := range cases { | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| setOrUnset(t, INFISICAL_DOMAIN_ENV_NAME, tc.domain) | ||
| setOrUnset(t, LEGACY_INFISICAL_API_URL_ENV_NAME, tc.apiURL) | ||
|
|
||
| got, ok := GetEnvDomain() | ||
| if ok != tc.wantOk { | ||
| t.Fatalf("ok = %v, want %v", ok, tc.wantOk) | ||
| } | ||
| if got != tc.wantVal { | ||
| t.Errorf("value = %q, want %q", got, tc.wantVal) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "workspaceId": "test-workspace-id", | ||
| "defaultEnvironment": "dev", | ||
| "gitBranchToEnvironmentMapping": null, | ||
| "domain": "https://custom.infisical.com" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.