Skip to content

fix(backfill): update dependencies in workflows to include botocore for improved AWS SDK compatibility#263

Merged
victorvhs017 merged 4 commits into
mainfrom
fix/pin-package-backfill-action
Jun 15, 2026
Merged

fix(backfill): update dependencies in workflows to include botocore for improved AWS SDK compatibility#263
victorvhs017 merged 4 commits into
mainfrom
fix/pin-package-backfill-action

Conversation

@victorvhs017

@victorvhs017 victorvhs017 commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Description 📣

Fixed the versions in action.

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-cli-263-fix-backfill-update-dependencies-in-workflows-to-include-botoc

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR explicitly pins botocore==1.20.5 alongside the existing boto3==1.17.5 dependency in both CI workflow pip install commands. botocore==1.20.5 is the canonical companion release for boto3==1.17.5 (boto3's own setup.py declares botocore>=1.20.5,<1.21.0), so the explicit pin prevents pip's dependency resolver from choosing an incompatible version when other packages in the same environment (e.g. mkrepo, univers) influence resolution.

  • Added botocore==1.20.5 to the pip install step in backfill-cloudsmith.yml (line 70).
  • Applied the identical change to the corresponding step in release_build_infisical_cli.yml (line 225), keeping both workflows consistent.

Confidence Score: 5/5

Two-line CI-only change that adds a missing explicit dependency pin; no logic changes and no production code touched.

Both workflows receive the same targeted fix, the pinned botocore version is the correct companion for the already-pinned boto3 version, and the change is isolated to pip install steps in CI jobs. No functional logic is altered.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/backfill-cloudsmith.yml Explicitly pins botocore==1.20.5 alongside boto3==1.17.5 to prevent dependency resolver from choosing an incompatible botocore version; versions are correctly matched.
.github/workflows/release_build_infisical_cli.yml Same botocore==1.20.5 pin applied consistently to the release build workflow, mirroring the backfill workflow change.

Reviews (1): Last reviewed commit: "Update dependencies in workflows to incl..." | Re-trigger Greptile

Victor Hugo dos Santos added 3 commits June 15, 2026 16:08
…ion script warnings

- Introduced a new `reindex` input to the backfill-cloudsmith workflow, allowing for forced regeneration of rpm/apk metadata.
- Updated the validation script to provide a warning for APKs that may be glibc-linked, improving clarity on potential execution issues.
…ironment

- Updated the installation step for mkrepo and dependencies to create a Python virtual environment, ensuring a cleaner and more isolated setup.
- Added the virtual environment's bin directory to the GitHub PATH for subsequent steps.
- Changed the Python version from 3.12 to 3.9 in both the backfill-cloudsmith and release_build_infisical_cli workflows to ensure compatibility and consistency across environments.
@victorvhs017 victorvhs017 requested a review from PrestigePvP June 15, 2026 21:13
@victorvhs017 victorvhs017 merged commit 483677e into main Jun 15, 2026
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants