Repository navigation
fix(postgres): always-on is the database default; limits stops echoing a queued resize as applied - #370
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
fix(postgres): always-on is the database default; limits stops echoing a queued resize as applied#370devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…hoes a queued resize as applied Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes from SUP2-212.
Default text. The platform now creates new databases always-on (
INSTA_DB_ALWAYS_ON_DEFAULT, unset = true). The CLI still called scale-to-zero the default in three places: thepostgres always-onhelp, the<redis|mysql|mongodb> always-onhelp, and thealwaysOnSetLineconfirmation. They now nameonas the default.postgres limits --cpu/--memoryprinted the old ceiling. In queue mode, insta-db answers a cpu/memory PATCH with a 202 carrying the instance row from before the patch, and the platform adapter marks itpending: true.dbLimitsprintedres.body.memoryMib, so a 4→2 GiB resize reportedceiling set to 4 vCPU / 4 GiB. The newlimitsSetLinehandles this the same wayalwaysOnSetLinehandles always-on:--jsonoutput is unchanged.Not changed:
service add postgres --always-on/--no-always-onis still refused client-side, though the platform acceptsalwaysOnfor databases. That is a product decision, left for a separate PR.MCP parity: no new command. The MCP
insta_add_servicedescription fix is in a separate instacloud-mcp PR.Gate:
npm run typecheck && npm testpasses (2168 tests).Link to Devin session: https://app.devin.ai/sessions/f83fc3a442e04e68977df5231d77f3a2
Open in Devin Desktop: https://app.devin.ai/desktop/session/f83fc3a442e04e68977df5231d77f3a2?variant=devin
Requested by: @tonychang04
Summary by cubic
Updates CLI help and confirmations to reflect always-on as the default for new databases, and stops
postgres limitsfrom echoing the old applied ceiling when a resize is still queued.onis now named as the default instead of scale-to-zero in thepostgres always-onand<redis|mysql|mongodb> always-onhelp and thealwaysOnSetLineconfirmation.pending: truemakeslimitsSetLinereport the requested ceiling as not yet applied and show the command to confirm later.--jsonoutput are unchanged.Written for commit 51b8e09. Summary will update on new commits.