Integration of the modelefiliere library #342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alicela
reviewed
Dec 5, 2025
src/main/java/fr/insee/genesis/controller/rest/responses/RawResponseController.java
Outdated
Show resolved
Hide resolved
| public DataProcessingContextModel getContextByCollectionInstrumentId(String collectionInstrumentId){ | ||
| return DataProcessingContextMapper.INSTANCE.documentToModel( | ||
| dataProcessingContextPersistancePort.findByPartitionId(partitionId) | ||
| dataProcessingContextPersistancePort.findByPartitionId(collectionInstrumentId) |
Contributor
There was a problem hiding this comment.
collectionInstrumentId is not a partition. Maybe change the def of "findByPartitionId" ?
…-API into devModeleFiliere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will receive the raw responses in a new format. Some identifiers change of name : for example questionnaireId become collectionInstrumentId, idUE become usualSurveyUnitId.
The new Raw responses will be persisted in a new collection. Then they will be processed (transformed in the Genesis model) and persisted in the same collection "responses".
Why so much change? Technically it could be a change only in the controller layer. It was possible to only impact that side of the application and leave our domain how it was before. However, this new model is something very structuring in our information system, and I think the application’s domain should comply with it. Overall, this refactor consisted in aligning our domain with the filière model (removing questionnaireId from the domain and switching to collectionInstrumentId), and handling, at the adapter level, the reading in the database of both the old and new documents.