-
Notifications
You must be signed in to change notification settings - Fork 4
usualSurveyUnitId bug fix + json export modele filiere fix + unit tests fix for modele filiere #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devModeleFiliere
Are you sure you want to change the base?
Conversation
+ fix: lunatic parsing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically a shortcut to run tests in intelliJ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branch bug fix : we get the first non null usual survey unit id for interrogation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hajar devs on filter result bug adaptation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed to not care about what we find in the database, I changed that, probably a merge conflit issue
| ddiFilePath = fileUtils.findFile(String.format("%s/%s", fileUtils.getSpecFolder(campaignName), modeName), DDI_FILE_PATTERN); | ||
| metadataModel = parseMetadata(ddiFilePath.toString(), true); | ||
|
|
||
| lunaticFilePath = fileUtils.findFile(String.format("%s/%s", fileUtils.getSpecFolder(campaignName), modeName), LUNATIC_FILE_PATTERN); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filter_result bug fix adaptation
| suDoc3.setCollectedVariables(List.of(new VariableDocument())); | ||
| suDoc3.setExternalVariables(List.of(new VariableDocument())); | ||
|
|
||
| suDocFiliere= new SurveyUnitDocument(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added filiere document
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit test of the new repository method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to modele filiere ids
| @@ -1,4 +1,8 @@ | |||
| # Changelog | |||
| ## 2.0.0 [TODO] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that with all the breaking changes the major should get incremented
src/test/resources/data_backup/data.complete.partial.STPDv1.20231122164209.xml
Show resolved
Hide resolved
|
|
||
| @AfterMapping | ||
| default void fillModelAfterRead(SurveyUnitDocument doc, | ||
| @SuppressWarnings("deprecation") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We handle deprecated fields, so we don't care of those warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple refactor to use the correct field
Feat update modele filiere 2 1 0
No description provided.