Skip to content

Conversation

@alexisszmundy
Copy link
Contributor

No description provided.

@alexisszmundy alexisszmundy changed the title Dev fix usual survey unit usualSurveyUnitId bug fix + unit tests fix for modele filiere Dec 19, 2025
@alexisszmundy alexisszmundy changed the title usualSurveyUnitId bug fix + unit tests fix for modele filiere usualSurveyUnitId bug fix + json export modele filiere fix + unit tests fix for modele filiere Dec 19, 2025
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically a shortcut to run tests in intelliJ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branch bug fix : we get the first non null usual survey unit id for interrogation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hajar devs on filter result bug adaptation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed to not care about what we find in the database, I changed that, probably a merge conflit issue

ddiFilePath = fileUtils.findFile(String.format("%s/%s", fileUtils.getSpecFolder(campaignName), modeName), DDI_FILE_PATTERN);
metadataModel = parseMetadata(ddiFilePath.toString(), true);

lunaticFilePath = fileUtils.findFile(String.format("%s/%s", fileUtils.getSpecFolder(campaignName), modeName), LUNATIC_FILE_PATTERN);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filter_result bug fix adaptation

suDoc3.setCollectedVariables(List.of(new VariableDocument()));
suDoc3.setExternalVariables(List.of(new VariableDocument()));

suDocFiliere= new SurveyUnitDocument();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added filiere document

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test of the new repository method

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed to modele filiere ids

@@ -1,4 +1,8 @@
# Changelog
## 2.0.0 [TODO]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that with all the breaking changes the major should get incremented


@AfterMapping
default void fillModelAfterRead(SurveyUnitDocument doc,
@SuppressWarnings("deprecation")
Copy link
Contributor Author

@alexisszmundy alexisszmundy Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We handle deprecated fields, so we don't care of those warnings

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple refactor to use the correct field

@Hajarel-moukh Hajarel-moukh self-requested a review December 22, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants