This repository was archived by the owner on Nov 26, 2025. It is now read-only.
Resolving conflicting values for padding_index#47
Merged
Conversation
…rences. Ruff format
…nto tokenized_text_tokens
…kenizer to exist)
micedre
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #43.
The padding index can be inferred from the tokenizer fields themselves, so
padding_indexis now considered as a tokenizer field. The model inherits from it but user can overwrite it, in that case the tokenizer's padding index is also updated.All default values for this field have been removed and replaced by the suitable field value.
The method
utils.tokenized_text_in_tokenshas been moved to a private instance method in the tokenizer's classtokenizer._tokenized_text_in_tokens, which is more natural. This method is used "internally" intokenizer.tokenizeandmodel.predict.