Skip to content

COMP: Improve ITKVtkGlue build robustness on Windows and with unusable VTK #6848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzenanz merged 2 commits into from
Sep 6, 2026
+43 −0
Merged

COMP: Improve ITKVtkGlue build robustness on Windows and with unusable VTK #6848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10b1e7c
COMP: Reject unusable VTK configurations at configure time
hjmjohnson Sep 6, 2026
29dd4df
COMP: Put VTK's DLL directory on PATH for the VtkGlue tests on Windows
hjmjohnson Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions Modules/Bridge/VtkGlue/itk-module-init.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,31 @@ if(NOT VTK_RENDERING_BACKEND STREQUAL "None")
)
endif()

if(ITK_WRAP_PYTHON)
if(NOT VTK_WRAP_PYTHON)
message(
FATAL_ERROR
"ITK_WRAP_PYTHON is ON and Module_ITKVtkGlue is enabled, but the VTK at\n"
" ${VTK_DIR}\n"
"was built with VTK_WRAP_PYTHON=OFF. Rebuild VTK with VTK_WRAP_PYTHON=ON,\n"
"or set Module_ITKVtkGlue=OFF."
)
endif()
# VTK exports no shared/static variable, so ask an imported target directly.
if(TARGET VTK::CommonCore)
get_target_property(_vtk_common_core_type VTK::CommonCore TYPE)
if(_vtk_common_core_type STREQUAL "STATIC_LIBRARY")
message(
FATAL_ERROR
"ITK_WRAP_PYTHON is ON and Module_ITKVtkGlue is enabled, but the VTK at\n"
" ${VTK_DIR}\n"
"is a static build. Its Python wrapping collapses into a single\n"
"_vtkmodules_static module that ITK's wrapping cannot import. Rebuild VTK\n"
"with BUILD_SHARED_LIBS=ON, or set Module_ITKVtkGlue=OFF."
)
endif()
unset(_vtk_common_core_type)
endif()
endif()

set(ITKVtkGlue_VTK_LIBRARIES ${_required_vtk_libraries})
16 changes: 16 additions & 0 deletions Modules/Bridge/VtkGlue/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,19 @@ if(NOT VTK_RENDERING_BACKEND STREQUAL "None")
REQUIRES_DISPLAY
)
endif()

# Windows has no RPATH, so VTK's DLLs must be on PATH at test time.
if(WIN32 AND TARGET VTK::CommonCore)
get_property(_vtkglue_tests DIRECTORY PROPERTY TESTS)
if(_vtkglue_tests)
set_property(
TEST
${_vtkglue_tests}
APPEND
PROPERTY
ENVIRONMENT_MODIFICATION
"PATH=path_list_prepend:$<TARGET_FILE_DIR:VTK::CommonCore>"
)
endif()
unset(_vtkglue_tests)
endif()
Loading