Skip to content

COMP: Label wrapped tests correctly and report the limited-API setting #6849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzenanz merged 2 commits into from
Sep 6, 2026
+31 −0
Merged

COMP: Label wrapped tests correctly and report the limited-API setting #6849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b55259
COMP: Label wrapped tests with their own module
hjmjohnson Sep 6, 2026
c7c9d43
COMP: Report the resolved Python limited-API setting
hjmjohnson Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions CMake/ITKSetPython3Vars.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,14 @@ else()
"SABIModule"
_SKBUILD_SABI_COMPONENT_REQUIRED
)
# A reconfigure sees the cached value, so remember how it was first set.
if(NOT DEFINED ITK_USE_PYTHON_LIMITED_API_WAS_AUTO)
if(NOT DEFINED ITK_USE_PYTHON_LIMITED_API)
set(ITK_USE_PYTHON_LIMITED_API_WAS_AUTO 1 CACHE INTERNAL "")
else()
set(ITK_USE_PYTHON_LIMITED_API_WAS_AUTO 0 CACHE INTERNAL "")
endif()
endif()
if(NOT DEFINED ITK_USE_PYTHON_LIMITED_API)
if(
(
Expand Down Expand Up @@ -139,7 +147,28 @@ else()
endif()
mark_as_advanced(ITK_USE_PYTHON_LIMITED_API)
endif()
if(ITK_USE_PYTHON_LIMITED_API_WAS_AUTO)
set(
_itk_limited_api_origin
"auto-selected from Python ${ITK_WRAP_PYTHON_VERSION}"
)
else()
set(_itk_limited_api_origin "requested")
Comment thread
hjmjohnson marked this conversation as resolved.
endif()
unset(_SKBUILD_SABI_COMPONENT_REQUIRED)
# The value auto-enables by interpreter version, so report what was chosen.
if(ITK_USE_PYTHON_LIMITED_API)
message(
STATUS
"Python wrapping: limited API (abi3) ON [${_itk_limited_api_origin}]"
)
else()
message(
STATUS
"Python wrapping: limited API (abi3) OFF [${_itk_limited_api_origin}]"
)
endif()
unset(_itk_limited_api_origin)
if(ITK_USE_PYTHON_LIMITED_API)
if(CMAKE_VERSION VERSION_LESS "3.26")
message(
Expand Down
2 changes: 2 additions & 0 deletions Wrapping/macro_files/itk_end_wrap_module.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,8 @@ ${DO_NOT_WAIT_FOR_THREADS_CALLS}
# Add testing
set(wrapping_test_directory ${CMAKE_CURRENT_SOURCE_DIR}/test)
if(BUILD_TESTING AND EXISTS ${wrapping_test_directory}/CMakeLists.txt)
# itk_add_test labels with ${itk-module}, which is unset in this scope.
set(itk-module ${WRAPPER_LIBRARY_NAME})
add_subdirectory(${wrapping_test_directory})
endif()
unset(wrapping_test_directory)
Expand Down
Loading