Skip to content

fix: remove localhost default from MarketingURL #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mastermanas805 merged 1 commit into from
Apr 23, 2026
Merged

fix: remove localhost default from MarketingURL #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/server/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,11 @@ func DefaultConfig() *Config {
ReadTimeout: "10s",
WriteTimeout: "30s",
IdleTimeout: "60s",
MarketingURL: "http://localhost:5173",
// Intentionally empty — an unset MarketingURL makes marketing
// redirects 404 cleanly. The old localhost default leaked into
// production OAuth redirects when operators forgot to set the
// env var, sending real users to http://localhost:5173.
MarketingURL: "",
CookieDomain: "",
AllowedOrigins: []string{
"http://localhost:5173",
Expand Down
3 changes: 3 additions & 0 deletions internal/server/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ func TestDefaultConfig(t *testing.T) {
if cfg.Email.FromAddress != "no-reply@example.com" {
t.Errorf("Email.FromAddress = %q, want %q", cfg.Email.FromAddress, "no-reply@example.com")
}
if cfg.Server.MarketingURL != "" {
t.Errorf("Server.MarketingURL default = %q, want empty string (no localhost leak in prod)", cfg.Server.MarketingURL)
}
}

// TestOverrideWithEnv_FillsEmptySecrets verifies env vars populate Config fields
Expand Down
Loading