Skip to content

fix: idempotent-by-name note no longer points free users at DELETE #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mastermanas805 merged 1 commit into from
Apr 23, 2026
Merged

fix: idempotent-by-name note no longer points free users at DELETE #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions internal/server/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,15 @@ func (s *server) handleNewDB(w http.ResponseWriter, r *http.Request) {
"connection_url": existing.connectionURL,
"tier": existing.tier,
"limits": map[string]any{"storage_mb": s.cfg.Postgres.StorageMB, "connections": s.cfg.Postgres.ConnLimit},
"note": fmt.Sprintf("Returning your existing %q database. Delete it via DELETE /api/me/resources/%s to provision a new one with this name.", name, existing.token),
}
// Paid users can DELETE; free users can't (DELETE returns 403
// paid_tier_only), so don't suggest it on the free-tier path —
// that would send them to an endpoint they can't use. Steer them
// to upgrade instead.
if existing.tier == "paid" {
resp["note"] = fmt.Sprintf("Returning your existing %q database. Delete it via DELETE /api/me/resources/%s to provision a new one with this name.", name, existing.token)
} else {
resp["note"] = fmt.Sprintf("Returning your existing %q database. Free-tier resources auto-expire in 24h; upgrade to Developer for manual delete + re-provision: %s/pricing.html", name, s.marketingURL)
}
if existing.expiresAt.Valid {
resp["expires_at"] = existing.expiresAt.Time
Expand Down Expand Up @@ -252,7 +260,13 @@ func (s *server) handleNewWebhook(w http.ResponseWriter, r *http.Request) {
"receive_url": existing.connectionURL,
"tier": existing.tier,
"limits": map[string]any{"requests_stored": s.cfg.Limits.WebhookMaxStored},
"note": fmt.Sprintf("Returning your existing %q webhook. Delete it via DELETE /api/me/resources/%s to provision a new one with this name.", name, existing.token),
}
// Same caveat as handleNewDB: don't point free-tier users at a
// DELETE endpoint they'd 403 on.
if existing.tier == "paid" {
resp["note"] = fmt.Sprintf("Returning your existing %q webhook. Delete it via DELETE /api/me/resources/%s to provision a new one with this name.", name, existing.token)
} else {
resp["note"] = fmt.Sprintf("Returning your existing %q webhook. Free-tier resources auto-expire in 24h; upgrade to Developer for manual delete + re-provision: %s/pricing.html", name, s.marketingURL)
}
if existing.expiresAt.Valid {
resp["expires_at"] = existing.expiresAt.Time
Expand Down
Loading