Skip to content

fix(artwork): log when a manual motion cover wins over the plugins - #797

Merged
InstaZDLL merged 1 commit into
mainfrom
fix/manual-motion-log
Oct 3, 2026
Merged

InstaZDLL merged 1 commit into
mainfrom
fix/manual-motion-log

Conversation

@InstaZDLL

@InstaZDLL InstaZDLL commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

What

fetch_album_motion_artwork returns a manual motion cover before the "resolving motion artwork" debug line runs. As a result, a diagnostic log shows nothing when a hand-set cover is on screen. On #766 this made a manual cover look like the plugin's. The plugin was then investigated for a cover it never produced.

  • Add a debug line when the manual cover wins. It logs the artist, the album and the album id.
  • Add a debug line when the album_motion_artwork row exists but its file is gone. The album then falls back to its static cover.
  • docs/features/plugins.md mentions both lines.

No behaviour change.

Checks

  • cargo fmt --check and cargo check pass.
  • Local CodeRabbit review: 0 findings.

Summary by CodeRabbit

  • Documentation

    • Précision des conditions dans lesquelles une couverture animée manuelle est utilisée à la place des plugins et du signalement d’un fichier manquant.
  • Corrections

    • Amélioration des logs lors de l’utilisation d’une couverture manuelle et lorsqu’un fichier associé est absent. Le comportement reste inchangé si ce fichier est introuvable.

A hand-set motion cover returned before the "resolving motion artwork"
line, so the log said nothing at all and the cover passed for a plugin's
(seen on #766). Log the manual hit, and the row whose file is missing,
at debug level.
@InstaZDLL InstaZDLL added scope: backend Rust/Tauri backend (src-tauri/) scope: docs Docs, README, assets type: fix Bug fix size: s 10-50 lines labels Oct 3, 2026
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (1)
AGENTS.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: InstaZDLL/WaveFlow/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 44f662a1-e37c-4377-90aa-6ae684842f62
📥 Commits

Reviewing files that changed from the base of the PR and between 1740008 and 32d8f80.

📒 Files selected for processing (2)
  • docs/features/plugins.md
  • src-tauri/crates/app/src/commands/motion_artwork.rs

Included review availability: This review used your included allowance. 8 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

Le code ajoute des messages debug lorsque la couverture manuelle prévaut ou que son fichier est absent. La recherche continue de renvoyer None si le fichier manque. La documentation décrit ces comportements.

Changes

Journalisation des couvertures manuelles

Layer / File(s) Summary
Recherche et journalisation des couvertures manuelles
src-tauri/crates/app/src/commands/motion_artwork.rs, docs/features/plugins.md
Le code journalise la couverture manuelle retenue et l’absence du fichier associé. La documentation précise que les plugins sont ignorés lorsqu’une couverture manuelle s’applique.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 32d8f

This PR adds diagnostics and documentation without changing artwork behavior; no material merge risk was identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Le titre suit le format Conventional Commits et décrit clairement l’ajout de logs lorsqu’une couverture animée manuelle est sélectionnée.
Description check ✅ Passed La description explique les deux cas journalisés et indique les vérifications exécutées. Elle ne reprend pas la checklist du modèle et ne confirme pas toutes les commandes demandées, mais elle fournit…
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@InstaZDLL InstaZDLL self-assigned this Oct 3, 2026
@InstaZDLL
InstaZDLL merged commit 689e021 into main Oct 3, 2026
17 checks passed
@InstaZDLL
InstaZDLL deleted the fix/manual-motion-log branch October 3, 2026 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: backend Rust/Tauri backend (src-tauri/) scope: docs Docs, README, assets size: s 10-50 lines type: fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant