fix(artwork): log when a manual motion cover wins over the plugins - #797
Conversation
A hand-set motion cover returned before the "resolving motion artwork" line, so the log said nothing at all and the cover passed for a plugin's (seen on #766). Log the manual hit, and the row whose file is missing, at debug level.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. 8 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughLe code ajoute des messages debug lorsque la couverture manuelle prévaut ou que son fichier est absent. La recherche continue de renvoyer ChangesJournalisation des couvertures manuelles
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to This PR adds diagnostics and documentation without changing artwork behavior; no material merge risk was identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
What
fetch_album_motion_artworkreturns a manual motion cover before the "resolving motion artwork" debug line runs. As a result, a diagnostic log shows nothing when a hand-set cover is on screen. On #766 this made a manual cover look like the plugin's. The plugin was then investigated for a cover it never produced.album_motion_artworkrow exists but its file is gone. The album then falls back to its static cover.docs/features/plugins.mdmentions both lines.No behaviour change.
Checks
cargo fmt --checkandcargo checkpass.Summary by CodeRabbit
Documentation
Corrections