Skip to content

fix(library): restore album artwork in Pulse and Lounge - #810

Merged
InstaZDLL merged 2 commits into
mainfrom
fix/album-artwork-skins
Oct 6, 2026
Merged

InstaZDLL merged 2 commits into
mainfrom
fix/album-artwork-skins

Conversation

@InstaZDLL

@InstaZDLL InstaZDLL commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Keep the album-cover hit target transparent across Pulse, Lounge, and Liquid, including high-contrast mode.
  • Preserve the original card-selector specificity and all album interactions.

Verification

  • bun run typecheck
  • bunx eslint src
  • bun run build
  • bunx prettier --check src/styles/skins/pulse.css src/styles/skins/lounge.css src/styles/skins/liquid.css
  • Two local coderabbit review --agent --base main passes: 0 findings each.
  • In bun run tauri dev, verified local album covers visually in all three skins; checked hover, keyboard focus, album opening, and the add-to-playlist menu. The active library had no remote albums to check visually.

bun run lint still reports errors in generated prototypes/flutter_mini/build JavaScript outside this change. Screenshots are omitted because the test library contains personal music data. No database migration.

Summary by CodeRabbit

  • Améliorations visuelles
    • Les boutons d’ouverture des vignettes d’album ne reçoivent plus les fonds, bordures, effets de survol et styles de verre appliqués aux autres cartes dans les thèmes Liquid, Lounge et Pulse.

@InstaZDLL InstaZDLL added scope: frontend React/Vite frontend (src/) type: fix Bug fix size: s 10-50 lines labels Oct 6, 2026
@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: InstaZDLL/WaveFlow/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5e7084f0-0092-4ec0-ad35-40fe924aa24b
📥 Commits

Reviewing files that changed from the base of the PR and between 3c21c62 and ba4d64a.

📒 Files selected for processing (4)
  • src/components/views/LibraryView.tsx
  • src/styles/skins/liquid.css
  • src/styles/skins/lounge.css
  • src/styles/skins/pulse.css

Included review availability: This review used your included allowance. 9 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.


📝 Walkthrough

Walkthrough

Le bouton superposé qui ouvre une vignette d’album reçoit l’attribut data-artwork-hit-target. Les sélecteurs concernés des skins Liquid, Lounge et Pulse excluent désormais ces éléments de certains styles de carte.

Changes

Cible d’image d’album

Layer / File(s) Summary
Marquage du bouton et exclusion des styles
src/components/views/LibraryView.tsx, src/styles/skins/liquid.css, src/styles/skins/lounge.css, src/styles/skins/pulse.css
Le bouton superposé d’ouverture d’album reçoit l’attribut data-artwork-hit-target. Les skins Liquid et Lounge excluent ces éléments de leurs règles de cartes, y compris les règles de contraste élevé indiquées. Le skin Pulse les exclut des styles de surface et de survol.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to ba4d6

The styling change preserves album artwork interaction while leaving ordinary card styling unchanged; no merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed Le titre est concis, respecte la convention « fix(library): … » et décrit la correction principale de l’affichage des pochettes.
Description check ✅ Passed La description résume l’objectif et détaille les vérifications effectuées. Elle explique l’absence de captures d’écran et signale les erreurs de lint hors périmètre. Les sections « Checklist » et « Li…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@InstaZDLL InstaZDLL self-assigned this Oct 6, 2026
@InstaZDLL
InstaZDLL merged commit dc15193 into main Oct 6, 2026
16 checks passed
@InstaZDLL
InstaZDLL deleted the fix/album-artwork-skins branch October 6, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: frontend React/Vite frontend (src/) size: s 10-50 lines type: fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant