Skip to content

feat(web): a lyrics view and an immersive view on the playing screen #213

Description

@InstaZDLL

Two views the desktop client has and the web client does not.

Lyrics

The server already serves them — getLyrics and getLyricsBySongId are both dispatched — and the playing screen already reads them. What is missing is a dedicated view: the lyrics as the subject of the screen rather than a strip beside the artwork, following the track where the server supplies timings.

Immersive

A full-screen mode built around the artwork and, where the track has one, its canvas. The canvas is already shipped (RFC-009: route, ticket, laying panel, playback on the playing screen, its own canvas test target) — this is the view that makes use of it.

Note the defect filed separately: a track with no canvas currently re-asks for a ticket on every mount. Landing that first keeps this view from multiplying the noise.

Why this is separate from the quality bar

Both sit on the playing screen, and grouping them was considered. The file-information work changes the shape of the wire; this does not. Mixing a wire change with interface work is how the four defects of #203 went unseen — the mocks confirmed the types instead of contradicting them. A pull request touching the wire deserves its own review.

Recorded in docs/ui-and-missing-features-plan.md, sections 2 and 5.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions