Wire visual regression & state-machine engine through all layers#212
Merged
Conversation
Two headless cores existed but were never exposed past their package, in violation of the project's "every feature ships headless + AC_ + GUI" rule. Complete them: - Visual regression: facade re-export of take_golden / compare_to_golden / DiffResult / MaskRegion; AC_take_golden and AC_assert_visual executor commands (assert auto-creates the baseline on first run, saves a diff on mismatch, raises like other AC_assert_*); ac_take_golden / ac_assert_visual MCP tools; Script Builder entries. - State machine: facade re-export of run_state_machine / StateMachine / StateMachineError; AC_run_state_machine command; ac_run_state_machine MCP tool; Script Builder entry. Adds headless tests (PIL images / specs injected) and a v6 new-features reference page (EN + Traditional Chinese) plus README sections.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 30 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Compare the floating-point diff_pct via pytest.approx instead of exact equality so SonarCloud's reliability gate stays green.
…-state-machine # Conflicts: # je_auto_control/__init__.py
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two headless cores existed in
utils/but were never exposed past theirown package — no facade re-export, no
AC_*command, no MCP tool, no GUI —in violation of the project's "every feature ships headless + AC_ + GUI"
rule. This completes both.
Visual regression (golden images)
take_golden,compare_to_golden,image_difference,DiffResult,MaskRegion.AC_take_golden— capture a baseline;AC_assert_visual— compare thescreen to a golden, auto-creating the baseline on first run, saving a
diff image on mismatch, and raising like every other
AC_assert_*.ac_take_golden,ac_assert_visual. Script Builder entries.Finite-state machine
run_state_machine,StateMachine,StateMachineError.AC_run_state_machineruns a declarative{initial, states}spec whoseon_enteractions execute through the executor; transitions fire onafter/if_var_eq/ predicate guards, bounded bymax_steps/global_timeout_s.ac_run_state_machine. Script Builder entry.Testing & docs
ruff/banditclean;import je_auto_controlstays Qt-free; noorphan Script Builder commands.
Independent of #211 (touches different files / different doc regions).