Add unattended/login reliability: OTP, file dialogs, session guard#217
Merged
Conversation
Three practitioner-pain fixes from the agent research, all full-stack and headless: - OTP/TOTP: generate_totp / verify_totp and AC_otp_to_var mint a 2FA code from a base32 secret (reusing the remote-desktop TOTP engine); also hardens verify_code against near-epoch negative counters. - File dialogs: handle_file_dialog / AC_handle_file_dialog wait for a native Open/Save/folder dialog, type the path and confirm, via an injectable FileDialogDriver. - Session guard: ensure_interactive_session / is_session_locked / AC_assert_session_active refuse to drive input into a locked or disconnected session (Windows input-desktop probe; injectable). Wired through facade, executor commands, ac_generate_otp / ac_handle_file_dialog / ac_assert_session_active MCP tools, Script Builder entries, headless tests, and a v9 reference page (EN + Traditional Chinese) + README sections.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 36 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three practitioner-pain fixes from the multi-agent research, completing
the actionable backlog for unattended / login automation. All full-stack
and headless.
generate_totp/verify_totp,AC_otp_to_var,ac_generate_otp: mint the current code from a base32secret (reuses the remote-desktop TOTP engine). Also hardens
verify_codeagainst near-epoch negative counters.handle_file_dialog,AC_handle_file_dialog,ac_handle_file_dialog: wait for the OS Open/Save/folder dialog, typethe path, confirm — via an injectable
FileDialogDriver.ensure_interactive_session/is_session_locked,AC_assert_session_active: refuse to drive inputinto a locked / disconnected session (Windows input-desktop probe;
injectable).
Facade re-exports, Script Builder entries, headless tests (no 2FA / real
dialog / locked session needed), and a v9 reference page (EN + Traditional
Chinese) + README sections.
ruff/radon/banditclean; Qt-free; noorphan Script Builder commands.