Add reactive screen observer (appear/vanish/change)#225
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 91 |
| Duplication | 4 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-2 web-research follow-up, batch 7 — a non-blocking screen observer (SikuliX
observemodel), wired through all five layers (facade,AC_*, MCP, Script Builder) with headless tests + EN/Zh v17 docs + README sections.Feature (
utils/observer)ScreenObserver— register watches that fire on appear / vanish / change of a value and run a callback;add/remove/names/poll_once/start/stop/fired. Complements the blockingwait_for_*family — react to dialogs/progress/status while the main flow continues.predicate(truthy = present); transition logic is unit-tested viapoll_once()with synthetic values, no real screen. Built-inimage_predicate/text_predicate/pixel_predicatewrap the existing locate/OCR/pixel helpers; errors are swallowed so the poll loop survives.AC_observe_add(kind=image/text/pixel, event=appear/vanish/change, runsactions— the watchdog pattern generalised to screen content) /AC_observe_remove/list/poll/start/stop+ac_observe_*.Verification
test/unit_test/headless/test_observer_batch.py— 7 tests pass (transition matrix, event filtering, error resilience, remove/names/log, full wiring).import je_auto_controlPySide6-free.