Skip to content

Silence Codacy Bandit B105 false positive in executor leak test #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JE-Chen merged 1 commit into from
Apr 25, 2026
Merged

Silence Codacy Bandit B105 false positive in executor leak test #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions tests/test_action_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,20 +112,16 @@ def test_duplicate_actions_do_not_collide() -> None:
assert list(results.values()) == ["first", "first"]


def test_substitute_does_not_leak_into_result_key() -> None:
def test_substitute_does_not_leak_into_result_key(monkeypatch: pytest.MonkeyPatch) -> None:
"""``substitute=True`` must keep the un-expanded literal in result keys."""
import os

os.environ["FA_EXEC_SECRET"] = "TOP_SECRET"
try:
executor = _fresh_executor()
results = executor.execute_action(
[["echo", {"value": "${env:FA_EXEC_SECRET}"}]],
substitute=True,
)
[(key, value)] = results.items()
assert "TOP_SECRET" not in key
assert "${env:FA_EXEC_SECRET}" in key
assert value == "TOP_SECRET"
finally:
os.environ.pop("FA_EXEC_SECRET", None)
sentinel = "sentinel-must-not-appear-in-key"
monkeypatch.setenv("FA_EXEC_LEAK_PROBE", sentinel)
executor = _fresh_executor()
results = executor.execute_action(
[["echo", {"value": "${env:FA_EXEC_LEAK_PROBE}"}]],
substitute=True,
)
[(key, value)] = results.items()
assert sentinel not in key
assert "${env:FA_EXEC_LEAK_PROBE}" in key
assert value == sentinel
Loading