Conversation
PyBreeze double-encodes the action list on Windows to survive command-line escaping; the registry refactor dropped the matching peel step, so the CLI saw a string and rejected the batch. Restore the unwrap with an isinstance(parsed, str) guard so single- and double-encoded payloads both work cross-platform. Cover both shapes in tests/test_cli_main.py.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 4 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_execute_str, sopython -m automation_file --execute_str <payload>rejected PyBreeze's payload withaction_list must be list, got str._execute_strnow unwraps a second JSON layer when the first decode yields a string. Guarded byisinstance(parsed, str)so single-encoded payloads work too — no platform check, same behaviour everywhere.tests/test_cli_main.py) covering the single- and double-encoded payload shapes.Test plan
pytest tests/test_cli_main.py— 4/4 passpyarrowparquet path, unrelated)subprocess.Popen([..., "-m", "automation_file", "--execute_str", json.dumps(json.dumps(actions))])— RC 0, target file writtenruff check/ruff format --checkclean on changed files