Conversation
- sanitize SUBJECT-derived filenames in output_all_mail_as_file and reject path traversal via basename, separator stripping, and a commonpath check so writes cannot escape cwd - validate socket server JSON payloads (shape, size, command-name types) before dispatching to the executor, and guard recv against buffer overflow and undecodable bytes - route library-code diagnostics through mail_thunder_logger instead of print(), and correct docstring placement in the IMAP wrapper
Add a Linter Compliance section to CLAUDE.md documenting the SonarQube, Codacy, Pylint, Flake8, and Bandit rules the codebase must satisfy, and bring existing modules into compliance: flatten deeply nested login flows, replace broad except swallows with specific exceptions, chain raises with `from` to preserve tracebacks, switch manual lock acquire/release to `with` blocks, remove redundant `object` inheritance and empty-placeholder f-strings, replace `dict()`/`list()` literals, and stop shadowing stdlib names. No behavioral changes; existing tests (53) still pass.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 13 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.mdencoding the SonarQube, Codacy, Pylint, Flake8, and Bandit rules this codebase must satisfy (complexity limits, naming, exception handling, mutable defaults, Bandit security hotspots, imports, formatting, docstrings).SMTPWrapper/IMAPWrappervia a shared_resolve_credentialshelper, chains re-raises withfrom, replaces manualLock.acquire()/release()withwith _lock:, narrows broadexcept Exceptionto specific exceptions, drops redundant(object)inheritance and empty-placeholder f-strings, and stops shadowing the stdlibsocketname in the socket handler.CLAUDE.mdproject guide and the filename/socket-payload hardening.Test plan
py -m pytest test/— 53 passed (the 2socket.gaierrorfailures intest_socket_serverare pre-existing environment issues unrelated to this change, reproducible onmain).