Conversation
- Validate package names against a strict module-identifier regex before find_spec/import_module so user-controlled inputs cannot reach dynamic import (Semgrep non-literal-import). - Use Sphinx project_copyright instead of redefining the copyright builtin in docs/source/conf.py (Pylint W0622). - Drop unused imports flagged by Prospector pyflakes in test_executor, test_get_dir_file_list, and test_json_file.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 6 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Semgrep flagged the compiled regex as a potential ReDoS pattern. Validating each dotted segment with str.isidentifier gives the same guarantee against shell/path payloads without any regex, removing the heuristic warning and reading more directly.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_spec/import_moduleinPackageManager.check_packageso user-controlled inputs cannot trigger dynamic import of arbitrary modules (Semgrepnon-literal-import).docs/source/conf.pyto Sphinx'sproject_copyrightalias to stop shadowing thecopyrightbuiltin (Pylint W0622).test_executor.py,test_get_dir_file_list.py, andtest_json_file.py.Test plan
pytest— 55/55 passing locally