Conversation
Pass argument list to subprocess.Popen on all platforms instead of using shell=True on Windows. Use shlex.split with posix=False on Windows to preserve backslash paths, and accept pre-split lists.
Add Static Analysis Compliance section to CLAUDE.md covering SonarQube, Codacy, Pylint, and Bandit rules for complexity, duplication, naming, correctness, security, typing, and tests. Narrow broad except Exception in ProcessManager.terminate_all to OSError and log at debug level instead of silently swallowing (python:S5754, python:S2737).
|
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 medium |
🟢 Metrics 0 complexity
Metric Results Complexity 0
TIP This summary will be updated as you push new changes. Give us feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.mdmapping concrete rules to SonarQube (python:S*), Codacy, Pylint, and Bandit (B*) identifiers — covering complexity, duplication, naming, correctness, security hotspots, typing, and tests.except Exception: passinProcessManager.terminate_all(python:S5754+python:S2737): narrow toexcept OSErrorand log at debug level instead of silently swallowing.Test plan
pytestpassespython -c "from test_pioneer.executor.run.process_manager import process_manager"imports cleanly (no circular import from new logger import)