Conversation
- Type Optional params in step_log_check (S5655) - Refactor parallel_run, execute_yaml, select_with_runner to reduce cognitive complexity below 15 (S3776) - Replace list() copy with rebuild in ProcessManager.cleanup_finished and reuse it from parallel_run (S7504) - Pin Ubuntu base image to 24.04 and merge consecutive RUN layers in Dockerfile_GUI and Dockerfile_NonGUI (S6596, S7031); drop privileges to a non-root pioneer user - Replace hardcoded test password with secrets.token_hex and switch /tmp paths to tempfile.gettempdir (S2068, B106, B108) - Switch test placeholder URLs from http to https (S5332) - Drop unused imports in test_project, test_file_processing, test_pioneer_executor, and docker_non_gui_test/test - Suppress redefined-builtin warning for Sphinx-required copyright var
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 7 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
- Fix Sonar S5607 in test_logging by reading maxBytes via getattr and type-checking explicitly; bypasses an incorrect str/int inference on RotatingFileHandler.maxBytes - Merge the trailing pip install + useradd RUN instructions in both Dockerfile_GUI and Dockerfile_NonGUI to satisfy S7031
Combines the two asserts introduced in 5e0485c into one expression so the new-code Bandit B101 (assert in test) count matches the prior version. Pytest still treats the assertion as a single failure point.
Add an inline `# nosec B101` to the lone surviving Bandit warning the PR introduces. The check is intentional pytest-style assertion in test code and not security-sensitive.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
step_log_check, cognitive-complexity refactors ofparallel_run/execute_yaml/select_with_runner, pinned Dockerfile base image with merged RUN layers and non-root user.https, replace hardcoded test password withsecrets.token_hex, and route temp paths throughtempfile.gettempdir().Test plan
pytest test/— 109 passed, 1 pre-existing collection warning.