Repository navigation
Add Go and Python code-quality checks - #65
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eee7b5d6e2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| py_files=() | ||
| while IFS= read -r -d '' file; do py_files+=("$file"); done < <(git ls-files --cached --others --exclude-standard -z -- '*.py') | ||
| if ((${#py_files[@]})); then uvx --from vulture==2.16 vulture "${py_files[@]}" --min-confidence 90; fi | ||
| go vet ./... |
There was a problem hiding this comment.
When a removal leaves a package-level Go function or method with no callers, this line still exits successfully: go vet has no unused-declaration analyzer (verified with a package containing only an unreferenced function). Consequently, the required cleanup check and its PR job permit the ordinary Go dead-code case they are intended to catch; add a declaration-aware Go analyzer or equivalent check.
AGENTS.md reference: AGENTS.md:L31-L33
Useful? React with 👍 / 👎.
1 participant
This adds a local and pull-request check for ProfitCtl's Go and Python code, plus guidance to inspect cross-file dependencies with Graphify before removal.
Validation:
bash scripts/check-dead-code.shpasses locally.