Use a no-op order manager for in-order queues#2299
Open
ndgrigorian wants to merge 5 commits intomasterfrom
Open
Use a no-op order manager for in-order queues#2299ndgrigorian wants to merge 5 commits intomasterfrom
ndgrigorian wants to merge 5 commits intomasterfrom
Conversation
3784662 to
849b0af
Compare
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2299/index.html |
849b0af to
115b184
Compare
Collaborator
Collaborator
Author
|
@antonwolfy @vlad-perevezentsev Please experiment with it as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in #2293, the
SequentialOrderManagerconstruct may not bring any benefit with in-order queues, and, with an in-order queue, an extension/function implementation has to insert events into theSequentialOrderManagerif using library calls which also useSequentialOrderManagerunnecessarily.To remedy this, this PR proposes adding a
_NoOpOrderManagerimplementation class thatSequentialOrderManagercan use when passed an in-order queue.The returned object isn't cached, as it's mostly a no-op. Notably, the
_NoOpOrderManagerstores the in-order queue that it was given, so thatwait()can callq.wait()so that the method is still meaningful.