Unify dpnp public API exports by refactoring __init__.py
#2666
+145
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-perevezentsev
requested review from
antonwolfy and
ndgrigorian
as code owners
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.20.0dev1=py313h509198e_60 ran successfully. |
antonwolfy
reviewed
Nov 17, 2025
| * Redesigned `dpnp.modf` function to be a part of `ufunc` and `vm` pybind11 extensions [#2654](https://github.com/IntelPython/dpnp/pull/2654) | ||
| * Refactored `dpnp.fft` and `dpnp.random` submodules by removing wildcard imports and defining explicit public exports [#2649](https://github.com/IntelPython/dpnp/pull/2649) | ||
| * Added support for the `out` keyword to accept a tuple, bringing ufunc signatures into alignment with those in NumPy [#2664](https://github.com/IntelPython/dpnp/pull/2664) | ||
| * Unified `dpnp` public API exports by consolidating function exports in `__init__.py` and removing wildcard imports [#2665](https://github.com/IntelPython/dpnp/pull/2665) [#2666](https://github.com/IntelPython/dpnp/pull/2666) |
Contributor
There was a problem hiding this comment.
Can we remove "--disable=c-extension-no-member" from .pre-commit-config.yaml now?
Contributor
There was a problem hiding this comment.
And E501 skipping in .flake8
Contributor
Author
There was a problem hiding this comment.
Probably you meant F403 : ‘from module import *’ used
Since some files that are to be removed in the future still contain wildcard imports I would prefer not to change flake8 config
dpnp/dpnp_algo/__init__.py:29:1: F403 'from dpnp.dpnp_algo.dpnp_algo import *' used; unable to detect undefined names
from dpnp.dpnp_algo.dpnp_algo import *
^
dpnp/dpnp_utils/__init__.py:29:1: F403 'from dpnp.dpnp_utils.dpnp_algo_utils import *' used; unable to detect undefined names
from dpnp.dpnp_utils.dpnp_algo_utils import *
^
dpnp/random/dpnp_iface_random.py:44:1: F403 'from dpnp.dpnp_algo import *' used; unable to detect undefined names
from dpnp.dpnp_algo import *
^
dpnp/random/dpnp_iface_random.py:45:1: F403 'from dpnp.dpnp_utils import *' used; unable to detect undefined names
from dpnp.dpnp_utils import *
^
dpnp/random/dpnp_iface_random.py:47:1: F403 'from .dpnp_algo_random import *' used; unable to detect undefined names
from .dpnp_algo_random import *
^
5 F403 'from dpnp.dpnp_algo.dpnp_algo import *' used; unable to detect undefined names
5
Contributor
There was a problem hiding this comment.
I'm fine to remove that in the follow up PR
7 tasks
vlad-perevezentsev
force-pushed
the
clean_init_exports
branch
from
c125538 to
e17f107
Compare
antonwolfy
approved these changes
Dec 17, 2025
Contributor
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @vlad-perevezentsev
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the remaining wildcard imports and
__all__declarations from internal modules and consolidates the corresponding exports indpnp/__init__.pyas part of the ongoing public API unification.This work follows #2665.