Removed support for arrays of 2-dimensional vectors in dpnp.cross#2950
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev1=py313h509198e_10 ran successfully. |
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
Collaborator
|
No base build to compare — drop-2d-vectors-in-cross into master |
vlad-perevezentsev
approved these changes
Jun 17, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
github-actions Bot
added a commit
that referenced
this pull request
Jun 17, 2026
) NumPy 2.5 expires the deprecation of 2-dimensional vectors in `numpy.cross`: the function now requires (arrays of) 3-dimensional vectors and raises `ValueError` otherwise. This PR brings `dpnp.cross` in line with that behavior. Dpnp had already deprecated 2-D vectors in `dpnp.cross` back in 0.17.0 (via `DeprecationWarning`), so this removes the deprecated path entirely. Note, `dpnp.cross` now rejects 2-D vectors unconditionally, including when running tests against `NumPy < 2.5` (where numpy.cross still computes a 2-D result). This is an intentional. a733826
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPy 2.5 expires the deprecation of 2-dimensional vectors in
numpy.cross: the function now requires (arrays of) 3-dimensional vectors and raisesValueErrorotherwise.This PR brings
dpnp.crossin line with that behavior.Dpnp had already deprecated 2-D vectors in
dpnp.crossback in 0.17.0 (viaDeprecationWarning), so this removes the deprecated path entirely.Note,
dpnp.crossnow rejects 2-D vectors unconditionally, including when running tests againstNumPy < 2.5(where numpy.cross still computes a 2-D result). This is an intentional.