Return complex arrays from eig / eigvals#2953
Open
antonwolfy wants to merge 4 commits into
Open
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2953/index.html |
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev1=py313h509198e_8 ran successfully. |
vlad-perevezentsev
approved these changes
Jun 17, 2026
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumPY 2.5 changed
numpy.linalg.eigandnumpy.linalg.eigvalsso that for general (non-symmetric) matrices they always return complex-typed eigenvalues, instead of value-dependently casting the result back to a real type when the imaginary parts happen to be zero. For real input, float64 now yields complex128 and float32 yields complex64.dpnp.linalg.eig / eigvals are thin NumPy fallbacks (the OneMKL geev routine is not yet wired up), so they inherit this behavior directly from the installed NumPy.
This PR brings dpnp's documentation in line with the new always-complex output.