Skip to content

Normalize line endings to LF - #399

Merged
antonwolfy merged 2 commits into
masterfrom
normalize-line-endings
Nov 9, 2026
Merged

antonwolfy merged 2 commits into
masterfrom
normalize-line-endings

Conversation

@antonwolfy

Copy link
Copy Markdown
Collaborator

Description

Three tracked files were stored with CRLF line endings, while every other file in the repository uses LF:

  • conda-recipe-cf/conda_build_config.yaml
  • conda-recipe/conda_build_config.yaml
  • mkl_fft/_init_helper.py

The current .gitattributes only sets *.sh text eol=lf. This PR replaces it with the rule that dpnp uses, which also covers shell scripts:

* text=auto eol=lf

It stores all text files with LF and checks them out with LF, .bat files included, as in dpnp. The files above are renormalized with git add --renormalize .. Their contents don't change: git diff --ignore-cr-at-eol shows only .gitattributes. The same change is proposed in IntelPython/mkl_random#203 and IntelPython/dpctl#2396.

Verification

  • Tests: not run; no code changes.
  • Lint: pre-commit run --files on the changed files, Linux (WSL): all hooks passed.

Not verified

CI, including Windows checkouts.

Checklist

  • NumPy/SciPy FFT API compatibility preserved, or the break is intentional and called out above.
  • Behavior changes have tests in mkl_fft/tests/; bug fixes have a regression test.
  • CHANGELOG.md updated under ## [dev] with a [gh-NNN] link, or the change isn't user-visible.

Use the same .gitattributes as dpnp, so that text files are stored with
LF, and renormalize the files that were stored with CRLF.

@jharlow-intel jharlow-intel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

Copilot AI balanced review requested due to automatic review settings November 9, 2026 17:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for this change.

No open issues 🎉

What changed in this PR

Standardizes line endings across mkl_fft without changing Python logic or conda build settings.

Changes:

  • Replaces the shell-only Git rule with * text=auto eol=lf for repository-wide LF normalization and checkout.
  • Converts three tracked files from CRLF to LF without changing their text.

The required root AGENTS.md was unavailable, so no further repository inspection was performed.

File Description
mkl_fft/​_init_helper.py Normalizes line endings to LF; initialization logic is unchanged.
conda-recipe/​conda_build_config.yaml Normalizes line endings to LF; build settings are unchanged.
conda-recipe-cf/​conda_build_config.yaml Normalizes line endings to LF; build settings are unchanged.
.gitattributes Applies LF normalization and checkout to automatically detected text files.

Review effort: Balanced

@antonwolfy
antonwolfy merged commit ab7da93 into master Nov 9, 2026
90 of 112 checks passed
@antonwolfy
antonwolfy deleted the normalize-line-endings branch November 9, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants